CRASM-3585: Update Findings Library DataGrid column visibility for enhanced privacy and usability #1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Display IP addresses instead of domain names in first column - Hide Organizations column for standard users only - Remove redundant IP column - Update accessibility labels for IP-focused interface
…anges - Change test expectations from domain names to IP addresses - Update regex patterns to match IP format instead of domain names - Fix failing assertions after Domains table column structure changes
…-removals-CRASM-3585
…ess column - Revert Domain Name column to display domain names instead of IP addresses - Add separate IP Address column positioned next to Domain Name column - Update aria-labels to reference domain names for improved accessibility - Fix test assertions to expect domain names instead of IP addresses
…olumn management - Replace array filtering with proper columnVisibilityModel approach - Hide Domain Name column by default until WAS data is available (with TODO) - Conditionally hide Organization column for standard users via visibility model
…ility - Update existing loading state test to expect IP addresses instead of domain names - Improve test coverage for columnVisibilityModel implementation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Fix CodeQL security warning "Missing regular expression anchor" - Change /example\.com|test\.com|sample\.org/ to /^(example\.com|test\.com|sample\.org)$/ - Prevents potential substring matching vulnerabilities
…r standard users - Remove Organization column from columns definition for standard users instead of hiding via columnVisibilityModel - Completely hides Organization option from column chooser menu for standard users - Simplify columnVisibilityModel logic since Organization filtering now handled at column definition level - Update test description to reflect that column is completely removed, not just hidden
- Filter out Domain Name column from columns array for all users (pending WAS data integration) - Prevents Domain Name column from appearing in Filters > Columns menu while disabled - Simplify columnVisibilityModel since Domain Name now filtered at column definition level - Update TODO comments to reflect new filtering approach for future WAS data restoration - Update test description to reflect complete column removal vs visibility hiding
- Remove complex userColumnVisibility state and useMemo logic - Use direct columnVisibilityModel state for cleaner implementation - Maintain column filtering logic in domCols useMemo for Domain Name and Organization columns - Simplify onColumnVisibilityModelChange handler
jsalinasnttdata
requested review from
aloftus23,
cduhn17,
nickviola,
rapidray12 and
schmelz21
as code owners
cduhn17
deleted the
jsalinas-findings-library-datagrid-column-removals-CRASM-3585
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR updates the Domains table in the Findings Library to temporarily hide the Domain Name column until Web Application Scanning (WAS) data source integration provides actual domain name resolution:
columnVisibilityModel(clean, semantic approach)Technical Implementation: Uses MUI DataGrid's built-in column visibility management instead of array filtering, providing cleaner code and better maintainability.
💭 Motivation and context
This change addresses CRASM-3585 based on design team feedback that the Domain Name column should be hidden until the WAS (Web Application Scanning) datasource integration is complete, as the current data only provides IP addresses without corresponding domain name resolution.
Implementation Approach:
This solution maintains user experience while awaiting backend data integration, with a clear path forward for restoration once WAS data becomes available.
🧪 Testing
/inventory/domains
Before:
After:
Standard users:
All other users:
✅ Pre-approval checklist
bump_versionscript if this repository is versioned and the changes in this PR warrant a version bump.✅ Pre-merge checklist
✅ Post-merge checklist