Conversation
Rakefile
Outdated
| # Handle different Rails versions | ||
| active_record_version = Gem::Version.new(ActiveRecord::VERSION::STRING) | ||
|
|
||
| if active_record_version >= Gem::Version.new("6.0") |
There was a problem hiding this comment.
should we be removing Rails 6.0 support?
There was a problem hiding this comment.
Agree, since it's not officially supported anymore and most of our app has moved on.
wendy-clio
left a comment
There was a problem hiding this comment.
It will be great to take the chance to remove the 6.x version support. The upgrade itself LG!
There was a problem hiding this comment.
Bug: Ruby 3.0 Excluded Despite Rails Compatibility
The CI matrix includes Ruby 3.0 but then excludes it from all Rails versions (7.0, 7.2, 8.0), leading to zero test jobs for Ruby 3.0. This is incorrect because Rails 7.0 officially supports Ruby 3.0, and the blanket exclusion contradicts the gemspec's required_ruby_version = '>= 3.0'.
.github/workflows/ci.yml#L19-L32
polymorphic_integer_type/.github/workflows/ci.yml
Lines 19 to 32 in 1f78519
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
@wendy-clio @anthonyoconnorclio Removed rails 6.x support! |
jeffadavidson
left a comment
There was a problem hiding this comment.
Took a look, mostly for CI changes as this is one of our few public repos so I wanted to make sure we didn't introduce any triggers like pull_request_target that can add security risks.
LGTM
Add Rails 8 Compatibility
What does this do?
Rails 8.0 support, allowing host applications using Rails 8 to use this gem without version conflicts.
How does it solve it?
"< 8"to"< 9.0"in gemspecGemfile.rails-8.0-stableand updated CI matrix3.4.0Testing?