Simplify error handling by removing SendTimeState is_valid #2218
+189
−215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniovicente
force-pushed
the
antonio/cleanup_last_sent
branch
from
02595c2 to
a519fac
Compare
Old code followed common C++ code patterns instead of Rust best practices
antoniovicente
force-pushed
the
antonio/cleanup_last_sent
branch
from
a519fac to
5b94bb7
Compare
antoniovicente
commented
Oct 28, 2025
| } | ||
|
|
||
| struct BBRv2CongestionEvent { | ||
| struct BBRv2CongestionEventMeta { |
There was a problem hiding this comment.
Not too happy with this new struct. Would consider just passing in the 4 members as arguments to on_congestion_event_start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old code followed common C++ code patterns instead of Rust code patterns.
Not having the is_valid data member makes the code less error prone.