Skip to content

Expose load_verify_locations_from_file and load_verify_locations_from_directory to tokio-quiche QuicSettings #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ronhombre wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Expose load_verify_locations_from_file and load_verify_locations_from_directory to tokio-quiche QuicSettings #2272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc742b7
Expose `load_verify_locations_from_file` and `load_verify_locations_f…
ronhombre Dec 5, 2025
cfa30c6
Also expose to server mode (listen)
ronhombre Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion tokio-quiche/src/quic/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,16 @@ where
}
}

if let Some(verify_file) = &params.settings.verify_file {
log::info!("setting up verify_file"; "verify_file"=>verify_file);
&client_config.quiche_config.load_verify_locations_from_file(verify_file);
}

if let Some(verify_directory) = &params.settings.verify_directory {
log::info!("setting up verify_directory"; "verify_directory"=>verify_directory);
&client_config.quiche_config.load_verify_locations_from_directory(verify_directory);
}

// Set the keylog file here for the same reason
if let Some(keylog_file) = &client_config.keylog_file {
log::info!("setting up keylog file");
Expand Down Expand Up @@ -291,7 +301,17 @@ where
"O_NONBLOCK should be set for the listening socket"
);

let config = Config::new(params, socket.capabilities).into_io()?;
let mut config = Config::new(params, socket.capabilities).into_io()?;

if let Some(verify_file) = &params.settings.verify_file {
log::info!("setting up verify_file"; "verify_file"=>verify_file);
&config.quiche_config.load_verify_locations_from_file(verify_file);
}

if let Some(verify_directory) = &params.settings.verify_directory {
log::info!("setting up verify_directory"; "verify_directory"=>verify_directory);
&config.quiche_config.load_verify_locations_from_directory(verify_directory);
}

let local_addr = socket.socket.local_addr()?;
let socket_tx = Arc::new(socket.socket);
Expand Down
20 changes: 20 additions & 0 deletions tokio-quiche/src/settings/quic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,26 @@ pub struct QuicSettings {
/// Path to a directory where QLOG files will be saved.
pub qlog_dir: Option<String>,

/// Specifies a file where trusted CA certificates are stored for the
/// purposes of certificate verification.
///
/// The content of `file` is parsed as a PEM-encoded certificate chain.
///
/// See [`load_verify_locations_from_file()`]
///
/// [`load_verify_locations_from_file()`]: https://docs.quic.tech/quiche/struct.Config.html#method.load_verify_locations_from_file
pub verify_file: Option<String>,

/// Specifies a directory where trusted CA certificates are stored for the
/// purposes of certificate verification.
///
/// The content of `dir` a set of PEM-encoded certificate chains.
///
/// See [`load_verify_locations_from_directory()`]
///
/// [`load_verify_locations_from_directory()`]: https://docs.quic.tech/quiche/struct.Config.html#method.load_verify_locations_from_directory
pub verify_directory: Option<String>,

/// Congestion control algorithm to use.
///
/// For available values, see
Expand Down