Mid-DATA stream reset #2278
Open
Mid-DATA stream reset #2278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@icing can you try this branch out to see if it addresses your failing curl tests? |
|
Thanks @LPardue , with this patch I can no longer reproduce the bug. I'll disable the test in curl until we see a quiche version higher than 0.24.4. |
icing
added a commit
to icing/curl
that referenced
this pull request
Dec 10, 2025
Let nhttpx only use http/1.1 to backend. This reproduces the bug in quiche with higher frequency. Allow test_14_05 to now return a 400 in addition to the 431 we get from a h2 backend to nghttpx. Skip test_05_02 in h3 on quiche not newer than version 0.24.4 in which its bug is fixed (cloudflare/quiche#2278)
vszakats
pushed a commit
to curl/curl
that referenced
this pull request
Dec 10, 2025
Let nghttpx only use http/1.1 to backend. This reproduces the bug in quiche with higher frequency. Allow test_14_05 to now return a 400 in addition to the 431 we get from a h2 backend to nghttpx. Skip test_05_02 in h3 on quiche not newer than version 0.24.4 in which its bug is fixed: cloudflare/quiche#2278 Ref: cloudflare/quiche#2277 Closes #19770 (original Issue) Closes #19916
LPardue
force-pushed
the
lucas/mid-data-reset-as-finished
branch
from
8f79de7 to
0167337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to use a unit test to emulate the behaviour described in #2277, where the peer clams to send a DATA frame of length N but sends fewer bytes than that and resets the stream. This seems to trigger an erroneous Event::Finished event that confuses applications.
Ideally, we fix the underlying logic and thus will need to change the test to match.