feat: use Node.js LTS (v24) #182
Open
+176
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…e#181) * Revert "Use environment protection for external PRs (cloudflare#180)" This reverts commit 08ea6f4. * Revert label based CI workflow
) * Fix foreground commands blocking on background processes Foreground commands (exec, listFiles) would hang until background processes completed. This was caused by wait without arguments in the foreground pattern, which waits for ALL shell child processes. Bash waits for process substitutions automatically, so the explicit wait was unnecessary. Removing it fixes the hang. * Add changeset * Fix race condition in foreground exec pattern Process substitutions write asynchronously - bash returns when substitution processes close, but writes may still be buffered. With large output (base64-encoded files), the log could be incomplete when read, causing flaky CI failures. Replace process substitutions with direct file redirects. Bash waits for redirects to complete, ensuring logs are fully written before exit codes are published.
* build Python 3.11.11 from source and optimize image size by removing build dependencies * mark runtime libraries as manually installed and remove build dependencies * add ccache for faster builds and better img size * optimise the image * use comp python * cleanup * update lock file * fix lock * Reset package-lock.json to match main branch * fix checksums * Add back file package to Dockerfile The file command is required by FileService for MIME type detection. Without it, all file read operations fail with 500 errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * less aggressive on cleanup post install * Update Python version to 3.11.14 * Remove Python cleanup from Dockerfile --------- Co-authored-by: Claude <[email protected]> Co-authored-by: Naresh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you know Node.js v24 (LTS) comes with builtin TypeScript support. In a project I'm currently working on I need to use Node.js and need to run TypeScript - so being able to run
.tsfiles without needing extra dependencies liketsxwould make a huge difference.node:lts-alpineand Node.js v24 from nodesource.com to verify it works.