add benchmark suite #867
Open
add benchmark suite #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Nov 19, 2025
| "bench": "npm run build && node run.js" | ||
| }, | ||
| "dependencies": { | ||
| "miniflare": "^4.20250923.0" |
Member
There was a problem hiding this comment.
it seems this is extremely old isn't it? can you also enable dependably on this path?
| "private": true, | ||
| "scripts": { | ||
| "build": "WASM_BINDGEN_BIN=../wasm-bindgen/target/debug/wasm-bindgen ../target/debug/worker-build --release", | ||
| "bench": "npm run build && node run.js" |
Member
There was a problem hiding this comment.
Suggested change
| "bench": "npm run build && node run.js" | |
| "bench": "node --run build && node run.js" |
| } | ||
|
|
||
| // Execute all tasks in parallel | ||
| let start = Date::now().as_millis(); |
Member
There was a problem hiding this comment.
this seems to be a not good path. can we use rdtsc?
| }, | ||
| "scripts": { | ||
| "build": "cd wasm-bindgen && cargo build -p wasm-bindgen-cli --bin wasm-bindgen && cd .. && cargo build -p worker-build", | ||
| "bench": "cd benchmark && npm run build && npm run bench", |
Member
There was a problem hiding this comment.
Suggested change
| "bench": "cd benchmark && npm run build && npm run bench", | |
| "bench": "cd benchmark && node --run build && node --run bench", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a benchmark to the repo as a self-contained app which sends 10 sub-requests back to the same worker with a payload of 1MB each.
This was a complete one-shot from Claude, and after thorough testing against various cases seems to work very well.