Skip to content

Conversation

@CFN-CI
Copy link
Contributor

@CFN-CI CFN-CI commented Sep 20, 2024

Automatic bump from version 2.8.10 to version 2.8.11, downloaded from https://www.haproxy.org/download/2.8/src/haproxy-2.8.11.tar.gz.

After merge, consider releasing a new version of haproxy-boshrelease.

@CFN-CI CFN-CI requested a review from a team September 20, 2024 05:40
@CFN-CI CFN-CI added the run-ci Allow this PR to be tested on Concourse label Sep 20, 2024
maxmoehl
maxmoehl previously approved these changes Sep 25, 2024
@maxmoehl
Copy link
Member

There is one set of changes in the CHANGELOG that could cause issues:

    - BUG/MINOR: h1: Fail to parse empty transfer coding names
    - BUG/MINOR: h1: Reject empty coding name as last transfer-encoding value
    - BUG/MEDIUM: h1: Reject empty Transfer-encoding header

@maxmoehl maxmoehl dismissed their stale review September 25, 2024 09:59

We need to check the changes more closely.

@maxmoehl maxmoehl requested a review from a team October 10, 2024 07:15
@peanball
Copy link
Contributor

Verified that any behavioural change in HAProxy does not impact apps, as Gorouter that sits behind HAProxy was already checking the Transfer-Encoding header with strict enough rules that this issue is of no consequence for CF apps behind Gorouter.

@peanball peanball merged commit fb744e7 into master Oct 23, 2024
3 checks passed
@peanball peanball deleted the haproxy-auto-bump-master branch October 23, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge run-ci Allow this PR to be tested on Concourse

Projects

Development

Successfully merging this pull request may close these issues.

3 participants