Skip to content

Conversation

@weili-broadcom
Copy link
Contributor

Description

Please include a summary of the change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

@weili-broadcom
Copy link
Contributor Author

@chombium Could you please help merge this PR? The GitHub check failed because golang was not bumped up. Tests passed in our pipeline after bumping up golang.

@chombium
Copy link
Contributor

Hi @weili-broadcom,

The Go version is not a problem The github.com/prometheus/common package has to be bumped to at least v0.66.

Copy link

@ZPascal ZPascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good overall, but the Prometheus common version should be updated to fix the associated issues.

@weili-broadcom
Copy link
Contributor Author

@chombium @ZPascal Sorry I didn't explain this clearly. There is a bump-dependencies step in our pipeline, which bumps golang as well as its dependencies. During the process, github.com/prometheus/common was bumped up; as a result, this test case failed because it uses an older version of prometheus/common. This fix is to update the test case so the pipeline's bump-up dependencies step can succeed. Without this fix, the pipeline will just stop with an error.

@chombium
Copy link
Contributor

chombium commented Jan 2, 2026

Hi @weili-broadcom,
thanks for the explanation. I still believe, that we shouldn't commit broken code in the master.
Please run the following commands in order to fix the failing tests

go get github.com/prometheus/common
go mod tidy
go mod vendor

This will update the package to it's latest version.

Copy link
Contributor

@chombium chombium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the understanding @weili-broadcom.

LGTM!

@github-project-automation github-project-automation bot moved this from Inbox to Pending Merge | Prioritized in Application Runtime Platform Working Group Jan 2, 2026
@chombium chombium merged commit 10a862f into cloudfoundry:main Jan 2, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Application Runtime Platform Working Group Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants