-
Notifications
You must be signed in to change notification settings - Fork 32
Fix text parser error caused by prometheus lib upgrade #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@chombium Could you please help merge this PR? The GitHub check failed because golang was not bumped up. Tests passed in our pipeline after bumping up golang. |
|
Hi @weili-broadcom, The Go version is not a problem The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good overall, but the Prometheus common version should be updated to fix the associated issues.
|
@chombium @ZPascal Sorry I didn't explain this clearly. There is a bump-dependencies step in our pipeline, which bumps golang as well as its dependencies. During the process, github.com/prometheus/common was bumped up; as a result, this test case failed because it uses an older version of prometheus/common. This fix is to update the test case so the pipeline's bump-up dependencies step can succeed. Without this fix, the pipeline will just stop with an error. |
|
Hi @weili-broadcom, go get github.com/prometheus/common
go mod tidy
go mod vendorThis will update the package to it's latest version. |
chombium
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix and the understanding @weili-broadcom.
LGTM!
Description
Please include a summary of the change.
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branchIf you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack