update dependencies #1732
update dependencies #1732
Conversation
| <swagger.version>1.6.16</swagger.version> | ||
| <jclouds.version>2.7.0</jclouds.version> | ||
| <guava.version>33.4.8-jre</guava.version> | ||
| <guava.version>33.5.0-jre</guava.version> |
There was a problem hiding this comment.
Guava dependency is used by jclouds and previously bump versions of guava lead to failures on different IaaS providers. This bump requires to run tests with objectstore on different iaas providers.
| <commons-codec.version>1.18.0</commons-codec.version> | ||
| <multiapps.version>2.39.0</multiapps.version> | ||
| <commons-codec.version>1.20.0</commons-codec.version> | ||
| <multiapps.version>2.40.0-SNAPSHOT</multiapps.version> |
There was a problem hiding this comment.
Reminder to adopt released version of multiapps
| </dependencies> | ||
| </dependencyManagement> | ||
|
|
||
| <distributionManagement> |
There was a problem hiding this comment.
Why this configuration was removed?
There was a problem hiding this comment.
I presume it was left for some kind of reference if the release can not be performed, since the releases are now following a different approach and working properly my understanding is to do not flood the pom with extra information. In addition the configuration can easily be found in the git history.
multiapps-controller-api/pom.xml
Outdated
| <groupId>io.swagger</groupId> | ||
| <artifactId>swagger-annotations</artifactId> | ||
| <version>1.6.16</version> | ||
| <scope>compile</scope> |
There was a problem hiding this comment.
- Why this dependency is needed now?
- All dependencies versions are set in parent pom.xml, not in child pom.xml.
- Is it really necessary to add this dependency at compile time? Isn't it necessary only at build time?
There was a problem hiding this comment.
This was mistakenly added due to migration to the next swagger. After deeper investigation the migration will be extracted to a separate PR as it requires complex changes to the code based on the changes applied to the new swagger version.
3 participants
LMCROSSITXSADEPLOY-3341