WIP: initialize OpenSAML in one class

[strehle]

No description provided.

[Copilot]

Pull Request Overview

Centralize OpenSAML initialization and parser/unmarshaller setup into a single utility class and update existing converters/providers to use it.

• Introduce OpenSamlXmlUtils to handle OpenSAML initialization, registry lookup, and provide parser/unmarshallers.
• Refactor Saml2BearerGrantAuthenticationConverter and OpenSaml4AuthenticationProvider to use OpenSamlXmlUtils instead of inline initialization.
• Minor formatting cleanup in Saml2Utils.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
server/src/main/java/org/cloudfoundry/identity/uaa/provider/saml/Saml2Utils.java	Removed extraneous blank line
server/src/main/java/org/cloudfoundry/identity/uaa/provider/saml/Saml2BearerGrantAuthenticationConverter.java	Switched to OpenSamlXmlUtils for initialization and parsing
server/src/main/java/org/cloudfoundry/identity/uaa/provider/saml/OpenSamlXmlUtils.java	New utility class for OpenSAML initialization and provider registry
server/src/main/java/org/cloudfoundry/identity/uaa/provider/saml/OpenSaml4AuthenticationProvider.java	Updated to use OpenSamlXmlUtils for parsing and unmarshalling

[Copilot]

This import is never used in the class. Consider removing SamlIdentityProviderDefinition to clean up unused imports.

Suggested change

import org.cloudfoundry.identity.uaa.provider.SamlIdentityProviderDefinition;

[Copilot]

The XMLObject import is not referenced in this class. Removing it will declutter the code.

Suggested change

import org.opensaml.core.xml.XMLObject;

[Copilot]

[nitpick] The method name initialize suggests side effects but only returns a boolean. Consider renaming to isInitialized or changing it to void initialize() to make its purpose clearer.

Suggested change

	public static boolean initialize() {
	public static boolean isInitialized() {