Improve Vibrator/Toy Support #18
Conversation
This reverts commit cc88f0e.
|
Thank you for taking the time to implement this. |
| @@ -0,0 +1,97 @@ | |||
| import { type GenericDeviceMessageAttributes, ActuatorType } from 'buttplug'; | |||
There was a problem hiding this comment.
Since the logic for toys has grown siginifcantly, it is no longer suitable to live in the utils folder.
Could you move these into their own toys folder, structured around this feature? (see e.g. the e621 folder).
There was a problem hiding this comment.
Moved these in 0df5bb6. Not sure if there's any further structuring we want to do? If you'd like me to split these files up further or move some other toy-related stuff into this folder, I'll do that. Let me know what you think.
| ); | ||
| }; | ||
|
|
||
| export const VibratorActuatorSettings: React.FC<ToySettingsProps> = ({ |
There was a problem hiding this comment.
This UI is very nested and feels somewhat hard to work with as a result.
I think we should come up with an alternative way to present this. perhaps a dialog would be in order?
I am still toying with the idea of rewriting all the UI in MUI but I have limited capacity at the moment.
It would however make things like this easier as we'd have more access to easy components without reinventing them every spot.
There was a problem hiding this comment.
I have started doing all that silly UI rewriting buisness. I'll let you know when thats ready so we can maybe think of something for this.
There was a problem hiding this comment.
Sounds good. UI/UX is not my passion, and the current solution is definitely a bit clunky. I originally wanted to put all of these into drop-down menus, but a dialog box would work too.
|
I implemented a basic PositionActuator, which is what TheHandy is on intifiace, I made a slight change and put the actuators in their own folder instead of one file but it's not important, feel free to use any of the work on my branch as you continue with this, mostly added just for personal use. |
3 participants
Replaced the vibrator support with a more generic "toy" support. A toy can have any number of actuators, and each actuator can be set run at different times. Adding support for new types of actuators should be a relatively straightforward task by following the structure of the existing "vibrate" actuator support.