-
Couldn't load subscription status.
- Fork 572
Settings and initial contents for Vietnamese localization #3461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @cjyabraham |
Sure, that's done. |
Signed-off-by: The Anh Nguyen <[email protected]>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @seokho-son can you review this PR? |
Signed-off-by: The Anh Nguyen <[email protected]>
|
Could you take a look this PR from a localization perspective? |
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Okabe-Junya for tagging!
I’ve reviewed the PR from a localization point of view and everything looks good to me.
/lgtm
|
/lgtm |
|
Hi @seokho-son @Okabe-Junya can you help me review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contirubution, LGTM!
Let’s hold off on merging this PR until we've received approval from Seokho Son-ssi (or another maintainer).
Deploy preview: https://deploy-preview-3461--cncfglossary.netlify.app/vi/
|
Nice starting base ! Thanks! |

This PR is to initiate Vietnamese localization based on
Base and target branch of this PR is dev-vi which is development branch for Vietnamese localization.
This PR includes
[languages.vi]section inconfig.tomlSince Vietnamese localization team owns content/vi/* only,
this PR will require approvals from upstream owners (maintainers).