Skip to content

Conversation

@ntheanh201
Copy link
Collaborator

This PR is to initiate Vietnamese localization based on

Base and target branch of this PR is dev-vi which is development branch for Vietnamese localization.

This PR includes

  • [languages.vi] section in config.toml
  • content/vi/ directory
  • i18n/vi.toml
  • Some translated documents
    • Main page
      • content/vi/_index.md
    • Others
      • contribute: content/vi/contribute/_index.md (partially localized)
      • style-guide: content/vi/style-guide/_index.md (partially localized)

Since Vietnamese localization team owns content/vi/* only,
this PR will require approvals from upstream owners (maintainers).

@ntheanh201
Copy link
Collaborator Author

image

@seokho-son
Copy link
Collaborator

Hi @cjyabraham
Could you enable netlify for the new branch dev-vi ? :)

@cjyabraham
Copy link
Contributor

Hi @cjyabraham Could you enable netlify for the new branch dev-vi ? :)

Sure, that's done.

@netlify
Copy link

netlify bot commented Apr 18, 2025

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 620d488
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6801c6a9a5e5d4000846a421
😎 Deploy Preview https://deploy-preview-3461--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ntheanh201
Copy link
Collaborator Author

Hi @seokho-son can you review this PR?

@seokho-son seokho-son added the lang/vi for Vietnamese label Apr 18, 2025
Signed-off-by: The Anh Nguyen <[email protected]>
@Okabe-Junya
Copy link
Collaborator

@thuanpham582002 @thaomike

Could you take a look this PR from a localization perspective?

@thaomike
Copy link
Collaborator

/lgtm

Copy link
Collaborator

@thuanpham582002 thuanpham582002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Okabe-Junya for tagging!

I’ve reviewed the PR from a localization point of view and everything looks good to me.
/lgtm

@trieungoctam
Copy link
Contributor

/lgtm

@ntheanh201
Copy link
Collaborator Author

Hi @seokho-son @Okabe-Junya can you help me review this PR?

Copy link
Collaborator

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contirubution, LGTM!
Let’s hold off on merging this PR until we've received approval from Seokho Son-ssi (or another maintainer).

Deploy preview: https://deploy-preview-3461--cncfglossary.netlify.app/vi/

@seokho-son
Copy link
Collaborator

Nice starting base ! Thanks!

@seokho-son seokho-son merged commit 8368f62 into cncf:dev-vi Apr 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang/vi for Vietnamese

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants