Skip to content

Conversation

@thuanpham582002
Copy link
Collaborator

Describe your changes

Add Vietnamese translation for Mutual Transport Layer Security (mTLS) concept

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@thuanpham582002 thuanpham582002 self-assigned this Apr 23, 2025
@github-actions github-actions bot added the lang/vi for Vietnamese label Apr 23, 2025
@netlify
Copy link

netlify bot commented Apr 23, 2025

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 7c9e646
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6808731a6b39bb0008f4a0e1
😎 Deploy Preview https://deploy-preview-3471--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thuanpham582002
Copy link
Collaborator Author

/cc @ntheanh201

Copy link
Collaborator

@ntheanh201 ntheanh201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thuanpham582002 anh có mấy góp ý, em xem có hợp lý không nhé

@Okabe-Junya
Copy link
Collaborator

Thank you for your contribution!

From a localization perspective, we require at least two approvals.
we welcome as many reviews as possible, thanks!

@ntheanh201
Copy link
Collaborator

/cc @thaomike review PR của Thuận em nhé

@thuanpham582002
Copy link
Collaborator Author

@ntheanh201 i've update following your review

@ntheanh201
Copy link
Collaborator

/lgtm

1 similar comment
@thaomike
Copy link
Collaborator

/lgtm

Copy link
Collaborator

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let me merge as a maintainer!

@Okabe-Junya Okabe-Junya merged commit a2b92fe into cncf:dev-vi Apr 23, 2025
6 checks passed
@Okabe-Junya
Copy link
Collaborator

Sorry for the nit comment, but since cncf/glossary isn't a Kubernetes repository, bot (Prow) commands like /lgtm won't trigger any automation.

If you think "LGTM", please provide an approval in the GitHub review like this #3471 (review)

Again, thank you for all your contributions!!

@thuanpham582002 thuanpham582002 deleted the dev-vi branch April 24, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang/vi for Vietnamese

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants