- 
                Notifications
    You must be signed in to change notification settings 
- Fork 572
REQUEST: new /vi approver for @thaomike #3483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ✅ Deploy Preview for cncfglossary ready!
 To edit notification comments on pull requests, go to your Netlify site configuration. | 
Signed-off-by: The Anh Nguyen <[email protected]>
| Hello @seokho-son @Okabe-Junya | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)
Since thaomike has been continuously contributing and reviewing, I think it’s fine to move this PR forward.
Let's also get input from the other maintainers - what do you think?
Note: When you move forward with this PR, you need to open a PR to update permissions in cncf/people.
| Wait, please do not proceed with this yet. | 
| Feel free to unhold once we got 2nd approval | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
| Hi @thaomike Could you open a PR to cncf/people ? (reference: cncf/people#974) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub Username
@thaomike
List of contributions to the Glossary project
PR's