Skip to content

Conversation

@ntheanh201
Copy link
Collaborator

@netlify
Copy link

netlify bot commented Apr 27, 2025

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 55986f5
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/680e50f17716db000850f7f7
😎 Deploy Preview https://deploy-preview-3483--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: The Anh Nguyen <[email protected]>
@ntheanh201
Copy link
Collaborator Author

Hello @seokho-son @Okabe-Junya
I would like to add @thaomike as an approver to the CODEOWNERS file in /vi. @thaomike has made valuable contributions to the Vietnamese l10n, including translating new terms and reviewing other contributors' PRs.

Copy link
Collaborator

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

Since thaomike has been continuously contributing and reviewing, I think it’s fine to move this PR forward.
Let's also get input from the other maintainers - what do you think?

Note: When you move forward with this PR, you need to open a PR to update permissions in cncf/people.

@Okabe-Junya Okabe-Junya added the hold Wait, please do not proceed this yet label Apr 28, 2025
@github-actions
Copy link

Wait, please do not proceed with this yet.

@Okabe-Junya
Copy link
Collaborator

Feel free to unhold once we got 2nd approval

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@seokho-son
Copy link
Collaborator

Hi @thaomike
Thank you for your contributions and for your willingness to take vi content approver role!

Could you open a PR to cncf/people ? (reference: cncf/people#974)

@seokho-son
Copy link
Collaborator

seokho-son commented Apr 30, 2025

Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thaomike we have invited you as a collaborator of this repo, and the status of invitation is "Pending". Please accept it, and you will get the write access to this repo.

All the requirements for merging this PR seem met, so let me unhold and merge. Thank you and welcome @thaomike !

@jihoon-seo jihoon-seo added maintainers Use this label if PR requires maintainers to take action lang/vi for Vietnamese and removed hold Wait, please do not proceed this yet labels May 1, 2025
@jihoon-seo jihoon-seo merged commit 79d39ac into cncf:main May 1, 2025
11 checks passed
@ntheanh201 ntheanh201 deleted the codeowners branch May 1, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang/vi for Vietnamese maintainers Use this label if PR requires maintainers to take action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants