Update Contribution Guide #3517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clude info about signing commits. Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>
iamNoah1
requested review from
Okabe-Junya,
caniszczyk,
hlipsig,
jihoon-seo,
nate-double-u and
seokho-son
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-project-automation
bot
moved this to 📋 Backlog
in CNCF glossary definition review board
iamNoah1
added
the
maintainers
|
To see where this is in the review pipeline and follow the progress, please look at the definition review board. |
nate-double-u
approved these changes
May 23, 2025
Member
nate-double-u
left a comment
nate-double-u
left a comment
There was a problem hiding this comment.
Thanks, @iamNoah1; I have a couple minor suggestions; otherwise, LGTM.
Co-authored-by: Nate W <[email protected]> Signed-off-by: Noah Ispas <[email protected]>
Co-authored-by: Nate W <[email protected]> Signed-off-by: Noah Ispas <[email protected]>
Collaborator
|
Please take a look #3517 (comment) and feel free to merge this PR, thanks again! |
Co-authored-by: Nate W <[email protected]> Signed-off-by: Noah Ispas <[email protected]>
github-project-automation
bot
moved this from 📋 Backlog
to ✅ Done
in CNCF glossary definition review board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update before you start section to remove obsolete information and include info about signing commits.
Describe your changes
Related issue number or link (ex:
resolves #issue-number)see #2017
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".