Skip to content

Merge dev-vi into main #3523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jun 11, 2025
Merged

Merge dev-vi into main #3523

merged 17 commits into from
Jun 11, 2025

Conversation

@ntheanh201
Copy link
Collaborator

@ntheanh201 ntheanh201 commented May 27, 2025

Describe your changes

Merge Vietnamese development branch into main.

Related issue number or link (ex: resolves #issue-number)

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

thuanpham582002 and others added 15 commits May 10, 2025 11:17
@thuanpham582002
[vi] add translation for zero-trust-architecture (#3489)
cea13f1 
Signed-off-by: thuanpham582002 <[email protected]>
@thuanpham582002
[vi] Add Vietnamese translation for Stateless Apps concept (#3501)
3002714 
Signed-off-by: thuanpham582002 <[email protected]>
@thuanpham582002
[vi] Add Vietnamese localization for Policy as Code concept (#3496)
f2b9773 
Signed-off-by: thuanpham582002 <[email protected]>
@thuanpham582002
[vi] Add Vietnamese translations for Platform as a Service (PaaS) (#3494
65c7086 
)

Signed-off-by: thuanpham582002 <[email protected]>
@thuanpham582002
[vi] Add Vietnamese translation for Loosely Coupled Architecture (#3493)
e1f2a5a 
Signed-off-by: thuanpham582002 <[email protected]>
@trungphuongm2k
[vi] Add Vietnamese localization for Immutable Infrastructure (#3507)
528ef2a 
Signed-off-by: trungphuongtt <[email protected]>
@thuanpham582002
[vi] Add Vietnamese translation for Stateful Apps (#3500)
6b68683 
Signed-off-by: thuanpham582002 <[email protected]>
@thuanpham582002
[vi] Add Vietnamese localization for Continuous Delivery concept (#3502)
2f441c5 
Signed-off-by: thuanpham582002 <[email protected]>
@trungphuongm2k @ntheanh201
[vi] Add Vietnamese translation for Infrastructure as Code (#3514)
60ca8b1 
Signed-off-by: trungphuongtt <[email protected]>
Signed-off-by: Trung Thi Phuong <[email protected]>
Co-authored-by: The Anh Nguyen <[email protected]>
@trungphuongm2k
[vi] Add Vietnamese translation for Infrastructure as a Service (#3516)
6b7a16f 
Signed-off-by: trungphuongtt <[email protected]>
@trungphuongm2k
[vi] Update index page with acknowledgement to Vietnamese contributors (
e4e5ad4 
#3518)

Signed-off-by: trungphuongtt <[email protected]>
@thuanpham582002
[vi] Add Vietnamese localization for Continuous Integration concept (#…
6af8674 
…3503)

Signed-off-by: thuanpham582002 <[email protected]>
@thuanpham582002
[vi] Add Vietnamese localization for Continuous Deployment concept (#…
eca2a31 
…3504)

Signed-off-by: thuanpham582002 <[email protected]>
@thaomike
[vi] Add Vietnamese localization for Auto Scaling (#3515)
6c36a25 
Signed-off-by: thaomike <[email protected]>
@huannd23012002
[vi] Add Vietnamese translation for Distributed Apps
818c748 
Signed-off-by: Nguyen Danh Huan <[email protected]>
@netlify
Copy link

netlify bot commented May 27, 2025 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit fdd591e
🔍 Latest deploy log https://app.netlify.com/projects/cncfglossary/deploys/683d600d5440b200089b6fd4
😎 Deploy Preview https://deploy-preview-3523--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the lang/vi for Vietnamese label May 27, 2025
@jihoon-seo jihoon-seo added the maintainers Use this label if PR requires maintainers to take action label May 28, 2025
jihoon-seo
jihoon-seo approved these changes May 28, 2025
View reviewed changes
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit history of this PR is so neat (all the PRs are squash-merged and all the commit messages have nice consistency), and I like it!
But I cannot find why the DCO check fails, since it seems that all the PR have proper DCO signatures.
We might bypass the DCO check again, like we did in the PR #3484.

@thuanpham582002
Copy link
Collaborator

thuanpham582002 commented May 30, 2025

add new term to follow up:

#3519

Okabe-Junya
Okabe-Junya reviewed May 30, 2025
View reviewed changes
Copy link
Collaborator

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all your contributions, great work!!
Almost LGTM, but let me confirm two things:

  1. I opened the PR to sync main <-> dev-vi. Before moving forward with this PR, let's merge this one
    a. #3525
  2. How to handle DCO fails (Do we need to bypass this again?)

@Okabe-Junya
Copy link
Collaborator

Okabe-Junya commented May 30, 2025

We might bypass the DCO check again, like we did in the PR #3484.

It looks good option for this PR, but we need to discuss about this problem for future...

@seokho-son
Merge pull request #3525 from cncf/main
fdd591e 
[maintain] Merge main into dev-vi
@seokho-son
Copy link
Collaborator

seokho-son commented Jun 11, 2025

@jihoon-seo @Okabe-Junya
I believe there is no additional difference regarding the DCO issue in this PR, given the decision made in #3484 (comment) .

The cause of the DCO issue is the same as explained in #3484 (comment)
, and it will likely continue unless all contributors adjust their Git settings accordingly or avoid using the "Apply suggestion" button in the GitHub UI.

Let me set bypass DCO check for this PR as well based on the same decision made in #3484 (comment) to not blocking localization team activity.

In the meantime, the maintainers should consider establishing a clear policy for handling DCO checks. (for instance, we can make DCO check exception for every PRs related with dev-xx branches)

seokho-son
seokho-son approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seokho-son seokho-son merged commit f50b799 into main Jun 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Okabe-Junya Okabe-Junya Okabe-Junya left review comments

@seokho-son seokho-son seokho-son approved these changes

@jihoon-seo jihoon-seo jihoon-seo approved these changes

@thuanpham582002 thuanpham582002 Awaiting requested review from thuanpham582002 thuanpham582002 is a code owner

@thaomike thaomike Awaiting requested review from thaomike thaomike is a code owner

Assignees

No one assigned

Labels

lang/vi for Vietnamese maintainers Use this label if PR requires maintainers to take action

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@ntheanh201 @thuanpham582002 @Okabe-Junya @seokho-son @jihoon-seo @trungphuongm2k @thaomike @huannd23012002