Skip to content

Comment thread inputs no longer enable the submit button when the default comment's body is not filled in #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArtOfCode- merged 5 commits into from
Jul 23, 2025
Merged

Comment thread inputs no longer enable the submit button when the default comment's body is not filled in #1702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
682933f
fixed server error when attempting to create threads failing validation
Oaphi Jul 23, 2025
cebb33e
moved new thread modal's char limits to the view's variables section
Oaphi Jul 23, 2025
2ebf341
ensured comment thread textarea is properly validated for max/min con…
Oaphi Jul 23, 2025
670de3e
fixed logic of character_count listener for changes
Oaphi Jul 23, 2025
84446c6
that's not how composite transactions work either... (fixed create_th…
Oaphi Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions app/assets/javascripts/character_count.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ $(() => {
$(document).on('keyup change paste', '[data-character-count]', (ev) => {
const $tgt = $(ev.target);
const $counter = $($tgt.attr('data-character-count'));
const $button = $counter.parents('form').find('input[type="submit"],.js-suggested-edit-approve');
const $form = $counter.parents('form');
const $button = $form.find('input[type="submit"],.js-suggested-edit-approve');
const $count = $counter.find('.js-character-count__count');
const $icon = $counter.find('.js-character-count__icon');

Expand All @@ -76,19 +77,24 @@ $(() => {
if (gtnMax || ltnMin) {
setCounterState($counter, 'error');
setCounterIcon($icon, 'fa-times');
setSubmitButtonDisabledState($button, 'disabled');
setInputValidationState($tgt, 'invalid');
} else if (gteThreshold) {
setCounterState($counter, 'warning');
setCounterIcon($icon, 'fa-exclamation-circle');
setSubmitButtonDisabledState($button, 'enabled');
} else {
setCounterState($counter, 'default');
setCounterIcon($icon, 'fa-check');
setSubmitButtonDisabledState($button, 'enabled');
setInputValidationState($tgt, 'valid');
}

const submittable = $form[0]?.checkValidity() ?? false;

if (!submittable || gtnMax || ltnMin) {
setSubmitButtonDisabledState($button, 'disabled');
} else {
setSubmitButtonDisabledState($button, 'enabled');
}

$count.text(text);
});

Expand Down
11 changes: 9 additions & 2 deletions app/controllers/comments_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,15 @@ def create_thread
pings = check_for_pings @comment_thread, body

success = ActiveRecord::Base.transaction do
@comment_thread.save!
@comment.save!
thread_success = @comment_thread.save
comment_success = @comment.save
full_success = thread_success && comment_success

unless full_success
raise ActiveRecord::Rollback
end

full_success
end

if success
Expand Down
18 changes: 15 additions & 3 deletions app/views/comments/_new_thread_modal.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
Start new comment thread dialog.
%>

<%
# TODO: make configurable
min_chars = 15
max_chars = 1000
%>

<div class="modal--container new-thread-modal" id="new-thread-modal-<%= post.id %>">
<div class="modal--header">
<b>Start a new comment thread</b>
Expand All @@ -18,9 +24,15 @@

<%= label_tag :body, 'Your comment', class: 'form-element' %>
<div class="form-caption">Start the thread with a comment.</div>
<%= text_area_tag :body, '', class: 'form-element js-comment-field', required: true,
data: { post: post.id, thread: '-1', character_count: ".js-character-count-#{post.id}" } %>
<%= render 'shared/char_count', type: post.id, min: 15, max: 1000 %>
<%= text_area_tag :body, '',
class: 'form-element js-comment-field',
minlength: min_chars,
maxlength: max_chars,
required: true,
data: { post: post.id,
thread: '-1',
character_count: ".js-character-count-#{post.id}" } %>
<%= render 'shared/char_count', type: post.id, min: min_chars, max: max_chars %>

<%= label_tag :title, 'Comment thread title (optional)', class: 'form-element' %>
<span class="form-caption">
Expand Down