Skip to content

Conversation

@Oaphi
Copy link
Member

@Oaphi Oaphi commented Nov 30, 2025

This PR fixes several issues with the dashboard:

  1. Answers from deleted users now show up as expected:
    image
  2. The leaderboard no longer shows undefined instead of username / language if either can't be determined (I chose "N/A" but not married to it - deferring to @trichoplax's judgment call):
    image
  3. The leaderboard now always renders in the correct place (before the number of answers header) - see the issue for details

closes #1911

As a side-effect of these changes, we now have two more hooks that userscripts / community assets can rely on: js-deleted-post and js-answers-header (neither of these is likely to go away, so let's make sure layout changes don't screw up with user-built stuff).

@Oaphi Oaphi requested review from cellio and trichoplax November 30, 2025 21:48
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.56%. Comparing base (a950c26) to head (0d96cc3).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 74.66% <ø> (ø)
helpers 84.91% <ø> (-0.49%) ⬇️
jobs 79.24% <ø> (ø)
models 90.01% <ø> (ø)
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trichoplax

This comment was marked as resolved.

@Oaphi

This comment was marked as resolved.

Copy link
Contributor

@trichoplax trichoplax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layout problem I mentioned in my original review turned out to be my error (I forgot to include the community CSS file in the head file). All working perfectly now.

Thanks very much for helping me spot this in Discord.

@Oaphi Oaphi merged commit 9dce9b1 into develop Dec 1, 2025
13 checks passed
@Oaphi Oaphi deleted the 0valt/1911/codegolf branch December 1, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code Golf leaderboard excludes answers from deleted users

3 participants