Skip to content

Update control panel icon #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gforcada wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update control panel icon #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/collective/solr/profiles/default/controlpanel.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
appId="SolrSettings"
category="Products"
condition_expr=""
icon_expr="string:${portal_url}/++resource++collective.solr.images/icon.png"
icon_expr="string:search"
Copy link
Member

@tisto tisto May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gforcada thanks for the fix. Just wondering, did you test this in Volto as well?

Copy link
Member Author

@gforcada gforcada May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, we might build one or two volto sites in the future, but so far we are still using classic UI

Copy link
Member

@davisagli davisagli May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to affect volto (which is ok):
Screenshot 2024-05-16 at 4 31 18 PM

url_expr="string:${portal_url}/@@solr-controlpanel"
visible="True"
i18n:attributes="title">
Expand Down