Skip to content

Remove five.globalrequest #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jensens merged 1 commit into from
Jun 23, 2025
Merged

Remove five.globalrequest #134

jensens merged 1 commit into from
Jun 23, 2025

Conversation

@cillianderoiste
Copy link
Member

@cillianderoiste cillianderoiste commented Jun 23, 2025

It has been integrated since Zope 4 and breaks in Plone 6.1.2

See: plone/Products.CMFPlone#2618

@cillianderoiste
Remove five.globalrequest
29d4c6e 
It has been integrated since Zope 4 and breaks in Plone 6.1.2

See: plone/Products.CMFPlone#2618
@jensens jensens merged commit d18aece into main Jun 23, 2025
@jensens jensens deleted the remove-five-globalrequest branch June 23, 2025 17:39
@krissik
Copy link

krissik commented Jun 25, 2025

Thanks a lot! When will this change be released?

@jensens
Copy link
Member

jensens commented Jun 25, 2025

as soon as the p6 branch is really ready for merge, some glitches seems to be left. See post here https://community.plone.org/t/did-anyone-run-pas-plugins-ldap-successfully-with-plone-6-0-9-or-have-any-other-ldap-solution/18709/21
any help appreciated!

@ale-rt
Copy link
Member

ale-rt commented Jun 26, 2025

@jensens can we make an intermediate release?

See this issue #113 (comment)

ale-rt added a commit to euphorie/osha.oira that referenced this pull request Jun 26, 2025
@ale-rt
Hack to fix the build
3267c1e 
This fixes the fact that we depend on `five.localsitemanager` through
`pas.plugins.ldap`.

See collective/pas.plugins.ldap#134
@ale-rt ale-rt mentioned this pull request Jun 26, 2025
Closed
@jensens
Copy link
Member

jensens commented Jun 27, 2025

can we make an intermediate release?

I can give you PyPI access for the project, so whats you username there?

@ale-rt
Copy link
Member

ale-rt commented Jun 27, 2025

can we make an intermediate release?

I can give you PyPI access for the project, so whats you username there?

Thanks @jensens It is alert.

@jensens
Copy link
Member

jensens commented Jun 27, 2025

can we make an intermediate release?

I can give you PyPI access for the project, so whats you username there?

Thanks @jensens It is alert.

Invite sent!

@ale-rt
Copy link
Member

ale-rt commented Jul 14, 2025

Thanks @jensens! Sorry but I have been on vacation and was not able to cut a release. I will do that now

@ale-rt ale-rt mentioned this pull request Jul 14, 2025
Merged
@ale-rt
Copy link
Member

ale-rt commented Jul 15, 2025

Note yesterday I did release https://pypi.org/project/pas.plugins.ldap/1.8.4/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cillianderoiste @krissik @jensens @ale-rt