Use react-spectrum styling for sidebar #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Manas-Kenge You can add css files in /theme now, #11 this PR had the fix , move the inline css to separate files . I think the volto css is getting overwritten by react-spectrum. React spectrum is using grid , there should be a way to solve it. You can take a look and debug it, else I will look into it later |
Also the expand button should not have the background color on hover fix it. And instead of black make the borders to the tabs greyish as in volto |
That is the default style for react-spectrum. I removed it in css file, not sure what you mean about the black borders. Is it the underline for active tab? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed semantic-ui and used react-spectrum. I am using inline css, not sure if I should create a separate css file. Also need to fix the problem of overlapping sidebar (Sidebar overlays on the page rather than resizing the page), I am unsure what is causing it.