Skip to content

Conversation

@esadek
Copy link
Contributor

@esadek esadek commented Nov 10, 2025

Add path filters to the Go and Integration workflows to skip runs for unrelated changes (e.g., documentation updates).

Copy link
Member

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems fine to me. An alternative would be to just ignore (paths-ignore) the docs folder. We can test this out though.

I'll let @zeroshade look before merging.

@esadek
Copy link
Contributor Author

esadek commented Nov 10, 2025

An alternative would be to just ignore (paths-ignore) the docs folder. We can test this out though.

My initial idea was to use paths-ignore, but there are many more files and folders to exclude beyond just docs/.

Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nitpicks, but otherwise looks good!

push:
branches:
- 'main'
paths:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also include .goreleaser.yaml and columnar.pubkey on the lists?

branches:
- "main"
paths:
- '**.go'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't these also have cmd/dbc/**?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants