-
Notifications
You must be signed in to change notification settings - Fork 6
chore: add path filters to workflows #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
amoeba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this seems fine to me. An alternative would be to just ignore (paths-ignore) the docs folder. We can test this out though.
I'll let @zeroshade look before merging.
My initial idea was to use |
zeroshade
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few nitpicks, but otherwise looks good!
| push: | ||
| branches: | ||
| - 'main' | ||
| paths: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also include .goreleaser.yaml and columnar.pubkey on the lists?
| branches: | ||
| - "main" | ||
| paths: | ||
| - '**.go' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't these also have cmd/dbc/**?
Add path filters to the Go and Integration workflows to skip runs for unrelated changes (e.g., documentation updates).