Check cycles on package level #141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debs-sifive
commented
Oct 29, 2024
Comment on lines
+58
to
+65
| private val pkgAccumulator = new tpd.TreeAccumulator[List[tpd.Tree]] { | ||
| def apply(acc: List[tpd.Tree], tree: tpd.Tree)(using Context): List[tpd.Tree] = | ||
| foldOver( | ||
| if (tree.symbol.is(Package) && tree.symbol.fullName.toString != "<empty>") tree :: acc else acc, | ||
| tree | ||
| ) | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
I copied the pattern in pkgObjectAccumulator for this, but I'm not sure that the behavior is correct or efficient. The packages appear to be repeated many more times with the foldOver compared to collect. This is how the packages compare between this Scala 3 plugin and the Scala 2 plugin:
Scala 3
stdPackages
Pkg(List(forcepkg, cyclicpackage, a))
Pkg(List(forcepkg, cyclicpackage, a))
Pkg(List(forcepkg, cyclicpackage))
Pkg(List(forcepkg))
Pkg(List(forcepkg, cyclicpackage))
Pkg(List(forcepkg, cyclicpackage))
Pkg(List(forcepkg))
Pkg(List(forcepkg, cyclicpackage, b))
Pkg(List(forcepkg, cyclicpackage, b))
Pkg(List(forcepkg, cyclicpackage, b))
Pkg(List(forcepkg, cyclicpackage, b))
Pkg(List(forcepkg, cyclicpackage))
Pkg(List(forcepkg))
Pkg(List(scala, annotation)) <-- idk where these are coming from
Pkg(List(scala)) <-- or if they should be here at all
Pkg(List(acyclic))
Pkg(List(acyclic))
Pkg(List(forcepkg, cyclicpackage))
Pkg(List(forcepkg, cyclicpackage))
Pkg(List(forcepkg))
Pkg(List(forcepkg, cyclicpackage, a))
Pkg(List(forcepkg, cyclicpackage, a))
Scala 2
stdPackages
Pkg(List(forcepkg, cyclicpackage, b))
Pkg(List(forcepkg, cyclicpackage, a))
Pkg(List(acyclic))
Pkg(List(forcepkg, cyclicpackage))
Pkg(List(forcepkg, cyclicpackage, b))
Pkg(List(forcepkg, cyclicpackage))
Pkg(List(forcepkg, cyclicpackage, a))
debs-sifive
force-pushed
the
package-cycles
branch
from
e321fe8 to
6722d01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #119 by jackkoenig which is a rebase of #30 originally by ghostbuster91