(lib)x265: Add versions 3.6 and 4.1 #28966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErniGH
previously approved these changes
Nov 24, 2025
Contributor
ErniGH
left a comment
ErniGH
left a comment
There was a problem hiding this comment.
LGTM
Thanks for updating the patches
Comment on lines
18
to
20
| +if(MSVC AND ARM64) | ||
| + add_definitions("-DHAVE_NEON") | ||
| +endif() |
Contributor
Contributor
Author
There was a problem hiding this comment.
Good question. I had a look at the buildfile diffs but didn't study all the thousands of changes to the code itself. Can recheck in the next days.
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Let's remove that then 👍
Contributor
Author
There was a problem hiding this comment.
Thanks for finding and fixing, I'd only have had time to check on the weekend now but that saves me some time for other stuff ;)
Co-authored-by: Francisco Ramírez <[email protected]>
Co-authored-by: Francisco Ramírez <[email protected]>
franramirez688
approved these changes
Nov 28, 2025
Contributor
franramirez688
left a comment
franramirez688
left a comment
There was a problem hiding this comment.
LGTM! Thanks @irieger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: libx265/3.6 & libx265/4.1
Motivation
I realized that the current version of libx265 is somewhat dated already (and not even on the official release server). Also the gitlab mirror isn't kept up to date so it might be better to pull downloads from the original source.
In the meantime, quite some work was spent in both performance optimization (arm especially) as well as feature additions.
Details
Release notes are hidden a bit in the upstream repository: https://bitbucket.org/multicoreware/x265_git/src/master/doc/reST/releasenotes.rst
Add a 👍 reaction to pull requests you find important to help the team prioritize, thanks!