[icu] Resolve issue #28972 by making the filename suffix 'b' on big-endan targets. #28974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on big-endan targets.
jcar87
reviewed
Nov 28, 2025
| vtag = Version(self.version).major | ||
| return f"icudt{vtag}l.dat" | ||
| arch = self.settings.get_safe("arch") | ||
| suffix = "b" if arch in {"ppc", "ppc64", "sparc", "sparc64", "mips"} else "l" |
Contributor
There was a problem hiding this comment.
Conan settings.yml does not have: ppc or sparc64 - should these be ppc32 and sparcv9?
mips64 would be missing in addition to mips
and I suspect s390 and s390x are also missing
As a general advice: when in doubt, rather than try to find a solution for every architecture, just fix the one that is causing you problems, and we can take care of the rest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: icu/[>=75.1]
The ICU Autotools build generates a datafile that has a different filename on big-endian systems, but the icu recipe had this hard-coded to the little-endian name, which caused failures during packaging on all big-endian targets.
Resolve by checking the target arch for some of the common big endian architectures, and using "b" for big "l" for little to match ICU's filename.
Motivation
Resolve issue #28972 by making the icu datafile dependent on the system architecture
Details
Add a 👍 reaction to pull requests you find important to help the team prioritize, thanks!