-
Notifications
You must be signed in to change notification settings - Fork 4
Add CLI stateful mode #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
qboileau
wants to merge
23
commits into
main
Choose a base branch
from
stateful-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marnas
reviewed
Dec 9, 2025
marnas
reviewed
Dec 9, 2025
marnas
reviewed
Dec 9, 2025
marnas
reviewed
Dec 9, 2025
marnas
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add a new opt-in stateful mode to the CLI apply/delete commands to keep track of managed resources.
This will be useful to keep in-sync a Conduktor resources living in yaml files inside a directory.
Behavior
When opt-in using either
--enable-stateflag orCDK_STATE_ENABLEDenv var.On first apply, all successfully created/updated/not changed resources found will be stored into a state file on CLI exit.
During following apply calls, state file is read back and list of managed resources are compared against list of resources found in yaml files.
If a resource is missing (removed from yaml source) it will be deleted from API and removed from the state.
Then remaining resources found and successfully applied are saved new updated state file.
Dry-run will not delete resources and change state file
State file
First implementation use a local json state file that track resources KVM (Kind/apiVersion/Medatada).
Default state file location depend on system :
$XDG_DATA_HOME/.local/share/conduktor/cli-state.jsonor$HOME/.config/conduktor/cli-state.json$HOME/Library/Application\ Support/conduktor/cli-state.json$APPDATA/conduktor/cli-state.jsonor$USERPROFILE/AppData/Roaming/conduktor/cli-state.jsonPath for state file can be configured using either
--state-filearg or env varCDK_STATE_FILEWhat this PR do
applyanddeletecommand1.24.9--dry-runsupport fordeletecommand