- 
                Notifications
    You must be signed in to change notification settings 
- Fork 112
feat(merge): include blob.meta in bootstrap for download optimization #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3e61b0b    to
    0d216b2      
    Compare
  
    | Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
+ Coverage   20.62%   20.97%   +0.35%     
==========================================
  Files         122      122              
  Lines       13706    11025    -2681     
==========================================
- Hits         2827     2313     -514     
+ Misses      10561     8393    -2168     
- Partials      318      319       +1     
 🚀 New features to boost your workflow:
 | 
546b147    to
    7b81649      
    Compare
  
    c3ac949    to
    9fd9592      
    Compare
  
    0e2b1ce    to
    f395899      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
others LGTM!
803bb00    to
    a975cc5      
    Compare
  
    Signed-off-by: Fan Shang <[email protected]>
a975cc5    to
    eefc9f4      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!

Overview
This is a maintenance change to include blob.metain the bootstrap data,
so that it can be downloaded together with the bootstrap file by reusing containerd's existing download logic.
Related Issues
No related issue.
Change Details
This change updates the bootstrap data construction in the merge process by including blob.meta.
Previously, blob.metawas not part of the bootstrap data, so it could not be downloaded together with the bootstrap file using containerd's existing logic.
With this change, blob.metais now integrated into the bootstrap data, enabling unified handling and download, and simplifying the overall process.
Test Results
Change Type
Self-Checklist