Skip to content

Conversation

@sf1999817
Copy link
Contributor

Overview

This is a maintenance change to include blob.metain the bootstrap data,

so that it can be downloaded together with the bootstrap file by reusing containerd's existing download logic.

Related Issues

No related issue.

Change Details

This change updates the bootstrap data construction in the merge process by including blob.meta.

Previously, blob.metawas not part of the bootstrap data, so it could not be downloaded together with the bootstrap file using containerd's existing logic.

With this change, blob.metais now integrated into the bootstrap data, enabling unified handling and download, and simplifying the overall process.

Test Results

image

Change Type

  • Bug Fix
  • Feature Addition
  • Documentation Update
  • Code Refactoring
  • Performance Improvement
  • Other (please describe)

Self-Checklist

  • I have run a code style check and addressed any warnings/errors.
  • I have added appropriate comments to my code (if applicable).
  • I have updated the documentation (if applicable).
  • I have written appropriate unit tests.

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 0% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.97%. Comparing base (d2c042a) to head (eefc9f4).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
pkg/converter/convert_unix.go 0.00% 73 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
+ Coverage   20.62%   20.97%   +0.35%     
==========================================
  Files         122      122              
  Lines       13706    11025    -2681     
==========================================
- Hits         2827     2313     -514     
+ Misses      10561     8393    -2168     
- Partials      318      319       +1     
Files with missing lines Coverage Δ
pkg/converter/convert_unix.go 0.00% <0.00%> (ø)

... and 113 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BraveY
Copy link

BraveY commented Sep 8, 2025

Thanks, please check the failed Smoke Test CI
image

@sf1999817 sf1999817 force-pushed the fix/merge-blob-meta branch 2 times, most recently from 546b147 to 7b81649 Compare September 11, 2025 08:20
@sf1999817 sf1999817 force-pushed the fix/merge-blob-meta branch 4 times, most recently from c3ac949 to 9fd9592 Compare September 24, 2025 12:53
@sf1999817 sf1999817 force-pushed the fix/merge-blob-meta branch 2 times, most recently from 0e2b1ce to f395899 Compare October 19, 2025 06:55
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM!

@sf1999817 sf1999817 force-pushed the fix/merge-blob-meta branch 11 times, most recently from 803bb00 to a975cc5 Compare October 27, 2025 12:43
@sf1999817 sf1999817 force-pushed the fix/merge-blob-meta branch from a975cc5 to eefc9f4 Compare October 28, 2025 05:00
@sf1999817 sf1999817 changed the title ​​chore(merge): include blob.meta in bootstrap for download optimization​ feat(merge): include blob.meta in bootstrap for download optimization Oct 28, 2025
Copy link

@BraveY BraveY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@imeoer imeoer merged commit 185c285 into containerd:main Oct 28, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants