[bugfix] workaround if some SegmentMapping refers to end of tar #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As pread(2) says: On success, pread() returns the number of bytes read (a return of zero indicates end of file) and pwrite() returns the number of bytes written. Note that it is not an error for a successful call to transfer fewer bytes than requested |
Add a unit test to test the recent regression. Signed-off-by: Gao Xiang <[email protected]>
|
Before: |
WaberZhuang
suggested changes
Oct 22, 2024
| LOG_ERRNO_RETURN(0, (int)ret, | ||
| "failed to read from `-th file ( ` pread return: ` < size: `)", | ||
| m.tag, m_files[m.tag], ret, size); | ||
| size_t ret2 = m_files[m.tag]->pread((char *)buf + ret, size - ret, m.moffset * ALIGNMENT + ret); |
Currently it could happen on EROFS meta indexes. Signed-off-by: Gao Xiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Workaround if some SegmentMapping refers to end of tar (because the mapping doesn't record real remote mapping size), which could happen on EROFS meta indexes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: