-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add changelog entry for PR #9253 #9255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fixes GitHub Issue #9249 Problem: - Mistral Large 3, Ministral 3, Gemma3 27B fail during MCP tool calling - Errors occur in Turn 2 when sending conversation + tool results back to model - Mistral/Ministral: 'Unexpected role system after role tool' - Gemma3: 'Invalid tool_calls: unknown variant index' Solution: - Created messageNormalizer.ts utility for model-specific message formatting - Integrated into streamChatResponse.ts before Ollama API calls - Mistral fix: Move system messages before tool interactions - Gemma fix: Remove 'index' field from tool_calls structure Testing: - Build successful (13.66 MB bundle) - No regression expected for 8 working models (Qwen3, Cogito, GLM, etc.) - Ready for testing with affected models Files: - extensions/cli/src/util/messageNormalizer.ts (NEW) - extensions/cli/src/stream/streamChatResponse.ts (MODIFIED) - SHIP_IDE_MODIFICATIONS.md (NEW - tracks all fork changes) This fix is generic and suitable for upstream PR contribution.
…ults Testing Complete: - All priority models working with MCP tools (DeepSeek V3.1, Qwen3 family, Cogito, GLM, Minimax, Kimi) - Gemma3 confirmed as known limitation (index field added after normalization) - Debug logging removed from messageNormalizer.ts - Documentation updated with actual test results Changes: - extensions/cli/src/util/messageNormalizer.ts: Removed console.log debug statements - SHIP_IDE_MODIFICATIONS.md: Added comprehensive test results section Status: - Message normalizer ready for Mistral/Gemma if needed in future - All Ship-IDE priority models confirmed working - GitHub issue #9249 documented with findings
Prepared comprehensive PR documentation for Continue.dev: - Problem statement and solution overview - Testing results with 8 working models - Implementation details and integration point - Backward compatibility notes - Known limitation (Gemma3) Ready to submit PR to continuedev/continue referencing issue #9249
Complete guide for submitting PR to Continue.dev: - Step-by-step fork and push instructions - PR template content ready in PR_DOCUMENTATION.md - Testing evidence summary - Post-PR merge actions - CLA signing reminder Status: Ready to create fork and submit PR to continuedev/continue
- Fix Ministral model detection (add explicit check for 'ministral') - Remove Ship-specific documentation files from PR - PR_SUBMISSION_GUIDE.md - SHIP_IDE_MODIFICATIONS.md - PR_DOCUMENTATION.md Addresses cubic bot review feedback on PR #9253
Co-authored-by: peter-parker <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 10 files
📚 Documentation Updates AvailableI've reviewed the changes in this PR and created a pull request with comprehensive documentation updates: PR #9256 - Documentation for Ollama MCP tool calling message normalization What's Documented✅ Troubleshooting guide - New section explaining automatic message normalization with error examples The documentation emphasizes that this feature works automatically with no configuration needed, which should help reduce support requests while making users aware of the improved compatibility. |
Co-authored-by: peter-parker <[email protected]>
This PR adds a changelog entry for PR #9253 that introduces message normalization for Ollama model compatibility.
Note: This PR should be merged into PR #9253 branch before that PR is merged to main.
Changes
Related PR
This agent session was co-authored by peter-parker and Continue.
Summary by cubic
Add message normalization for Ollama MCP tool calling and update the changelog, fixing Mistral Large 3, Ministral 3, and Gemma3 27B.
Written for commit 86d0800. Summary will update automatically on new commits.