- 
                Notifications
    You must be signed in to change notification settings 
- Fork 363
Opening this for comparison and review, NOT READY FOR MERGE #4779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            immber
  wants to merge
  31
  commits into
  coralproject:develop
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
immber:bsky-login
  
      
      
   
  
    
  
  
  
 
  
      
    base: develop
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    - proxy agents and secure pre-compute agents are missing in scraper.ts and in fetch.ts -> createFetch() func
| ✅ Deploy Preview for gallant-galileo-14878c canceled.
 | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Hi Coral! I'm opening a sample of a PR on my branch, based on previous conversations on this issue...
#4745
What does this PR do?
BskyAuthIntegrationtype ofsettingstotenantmodelBskyProfiletousermodelSignInWithBskyContainerform to streamauth/views/&& adminviews/SignInSignUpWithBskyContainerform to streamauth/views/BskyButtonframework components with butterfly svg/api/auth/bsky,/api/auth/bsky/callback,/api/auth/bsky/metadata.jsonhandlevalidation on the forms, with form error handlingBskyAuthIntegrationparent class that wraps Atproto'soauth-client-nodecreating the atproto/bluesky oauth client. (This client is currently instantiated and cached on the tenant, but might need to move this to a single instance per auth request instead)What is still missing to make this feature complete?
oauth-client-node... Automatic token refresh not working. TokenRefreshError: The session was deleted by another process bluesky-social/atproto#3637. When you authorize with a valid atproto handle, we see the errorThe session was deleted by another process. (I think this could be anotherfetchthing, bc of where it fails, still looking into this)jwks.jsonendpoint and connecting theclient secretvalue to the key generation. Currently some tokens are exposed in the browser.profileswhich means a Bsky session gets created, but a Coral one can not be. Once this bug is resolved or a workaround found, this still needs arevokelistener on theclientand a tokenrefreshhelper function to handle session events automatically.These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
BskyAuthIntegrationtype and adds it toAuthIntegrationsBskyProfiletype and adds it toProfileSettingsBskyAuthIntegrationInputinput and adds it toSettingsAuthIntegrationsInputDoes this PR introduce any new environment variables or feature flags?
nope
If any indexes were added, were they added to
INDEXES.md?no indexes
How do I test this PR?
To manually test:
Were any tests migrated to React Testing Library?
nope
How do we deploy this PR?
normally, but the per tenant client-metadata.json route needs to be tested, and correct URL callback values confirmed in a staging env prior to deploying to production envs.