-
Notifications
You must be signed in to change notification settings - Fork 122
Sync repo templates ⚙ #1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sync repo templates ⚙ #1253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request automatically updates the Fedora release version from f42 to f43 in the release checklist template. The change itself is correct. However, I've noticed an opportunity to improve the shell script example in the checklist. The current script is for a single branch, while the instructions mention multiple branches. I've left a comment suggesting a more robust script using a loop to handle multiple branches, which could make the release process less error-prone. This improvement could be considered for the upstream template repository.
| ```bash | ||
| git checkout rawhide | ||
| git pull --ff-only | ||
| git checkout f42 | ||
| git checkout f43 | ||
| git merge --ff-only rawhide | ||
| git push origin f42 | ||
| git push origin f43 | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instruction on line 103 mentions merging into 'other relevant branches' (plural), but the example script below only handles a single, hardcoded branch. This could be tedious and error-prone if multiple branches need updating.
To make the script more robust and align with the instruction, consider using a loop. This would make the process easier and safer. Here is a suggested improvement:
# Update for all relevant branches
BRANCHES="f43" # Add other branches here, space-separated (e.g., "f42 f43")
git checkout rawhide
git pull --ff-only
for branch in $BRANCHES; do
echo "--- Merging rawhide into $branch ---"
git checkout "$branch"
git merge --ff-only rawhide
git push origin "$branch"
doneeeecde3 to
05e7e8b
Compare
05e7e8b to
473297a
Compare
Created by GitHub workflow (source).
Sync with coreos/repo-templates@5386c91.