Skip to content

Conversation

@coreosbot-releng
Copy link

@coreosbot-releng coreosbot-releng commented Dec 3, 2025

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request automatically updates the Fedora release version from f42 to f43 in the release checklist template. The change itself is correct. However, I've noticed an opportunity to improve the shell script example in the checklist. The current script is for a single branch, while the instructions mention multiple branches. I've left a comment suggesting a more robust script using a loop to handle multiple branches, which could make the release process less error-prone. This improvement could be considered for the upstream template repository.

Comment on lines 104 to 110
```bash
git checkout rawhide
git pull --ff-only
git checkout f42
git checkout f43
git merge --ff-only rawhide
git push origin f42
git push origin f43
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The instruction on line 103 mentions merging into 'other relevant branches' (plural), but the example script below only handles a single, hardcoded branch. This could be tedious and error-prone if multiple branches need updating.

To make the script more robust and align with the instruction, consider using a loop. This would make the process easier and safer. Here is a suggested improvement:

# Update for all relevant branches
BRANCHES="f43" # Add other branches here, space-separated (e.g., "f42 f43")

git checkout rawhide
git pull --ff-only

for branch in $BRANCHES; do
  echo "--- Merging rawhide into $branch ---"
  git checkout "$branch"
  git merge --ff-only rawhide
  git push origin "$branch"
done

@travier travier added the skip-notes This PR does not need release notes label Dec 10, 2025
@travier travier enabled auto-merge December 10, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-notes This PR does not need release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants