Skip to content

Conversation

@chvck
Copy link
Collaborator

@chvck chvck commented Nov 25, 2025

No description provided.

@chvck chvck requested a review from Copilot November 25, 2025 16:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for JWT authentication in the Couchbase SDK by introducing a new JwtAuthenticator variant alongside the existing PasswordAuthenticator and CertificateAuthenticator.

Key Changes:

  • Added JwtAuthenticator enum variant and implementation with OAuth Bearer token support
  • Refactored HTTP authentication to use an Auth enum that supports both BasicAuth and BearerAuth
  • Modified authentication mechanism handling to automatically derive supported mechanisms from authenticator types
  • Simplified TLS configuration by auto-creating default TLS config when using couchbases:// scheme

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sdk/couchbase/src/authenticator.rs Added JwtAuthenticator struct and enum variant, removed unused UserPassPair and get_credentials method
sdk/couchbase/src/options/cluster_options.rs Updated TLS config handling to support JWT auth and auto-create TLS config for secure connections
sdk/couchbase/src/clients/cluster_client.rs Added automatic TLS config creation for couchbases:// scheme
sdk/couchbase-core/src/authenticator.rs Added JwtAuthenticator with auth mechanism support
sdk/couchbase-core/src/auth_mechanism.rs Added OAuthBearer authentication mechanism
sdk/couchbase-core/src/httpx/request.rs Added BearerAuth struct and Auth enum variant for JWT tokens
sdk/couchbase-core/src/httpcomponent.rs Refactored to use Auth enum, extracted auth_from_authenticator helper function
sdk/couchbase-core/src/memdx/* Added SASL OAuth Bearer operation support and refactored credential handling
sdk/couchbase-core/src/kvclient.rs Updated bootstrap authentication to derive mechanisms from authenticator type
sdk/couchbase-core/src/agent.rs Simplified auth mechanism default logic and updated HTTP config fetching to use Auth enum
Multiple management/query/search files Replaced separate username/password fields with unified auth field

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chvck chvck force-pushed the rscbc200 branch 5 times, most recently from fac759c to e6585fd Compare November 26, 2025 15:59
@chvck chvck force-pushed the rscbc200 branch 6 times, most recently from afe635b to b320cdd Compare December 3, 2025 12:50
@chvck chvck requested a review from Copilot December 3, 2025 13:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 45 out of 45 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chvck chvck merged commit 9bcbe9a into main Dec 3, 2025
23 of 28 checks passed
@chvck chvck deleted the rscbc200 branch December 3, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants