Skip to content

Conversation

@stefanosalvador
Copy link

Some gems conflict with newer version of other widely used gems. The changes are trivial and all tests passes.

Copy link

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase and hopefully someone will merge and release

@@ -1 +1 @@
2.2.0.beta2
2.2.0.beta5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote to release as 2.3.0

s.add_dependency("tzinfo", ">= 0.3.22")
s.add_dependency("hashdiff", "~> 0.3")
s.add_runtime_dependency("couchrest", "2.0.1")
s.add_runtime_dependency("activemodel", ">= 4.0.2")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe its time to drop < 5.2

if File.exists?(file)
YAML::load(ERB.new(IO.read(file)).result).symbolize_keys
if File.exist?(file)
YAML::load(ERB.new(IO.read(file)).result, aliases: true).symbolize_keys rescue YAML::load(ERB.new(IO.read(file)).result).symbolize_keys

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this line shorter, its a bit hard to read

Copy link

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have write access but I am happy to see activity.

CouchRest is a cool client for CouchDB in ruby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants