-
Notifications
You must be signed in to change notification settings - Fork 39
chore(atomic): migrate atomic-insight-edit-toggle to Lit #6848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(atomic): migrate atomic-insight-edit-toggle to Lit #6848
Conversation
Co-authored-by: alexprudhomme <[email protected]>
β¦oggle Co-authored-by: alexprudhomme <[email protected]>
Co-authored-by: alexprudhomme <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the atomic-insight-edit-toggle component from Stencil to Lit as part of the ongoing framework migration effort. The component provides an edit button for insight interfaces and is marked as internal.
Key Changes
- Converted component from Stencil's JSX syntax to Lit's template system
- Replaced Stencil decorators with Lit decorators (
@customElement,@property) - Added comprehensive test coverage (unit tests and E2E tests)
- Added Storybook documentation (stories and MDX file)
Reviewed changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
packages/atomic/src/components/insight/atomic-insight-edit-toggle/atomic-insight-edit-toggle.ts |
New Lit component implementation replacing Stencil .tsx file |
packages/atomic/src/components/insight/atomic-insight-edit-toggle/atomic-insight-edit-toggle.spec.ts |
New unit tests for the component |
packages/atomic/src/components/insight/atomic-insight-edit-toggle/e2e/atomic-insight-edit-toggle.e2e.ts |
New E2E tests |
packages/atomic/src/components/insight/atomic-insight-edit-toggle/e2e/fixture.ts |
E2E test fixture setup |
packages/atomic/src/components/insight/atomic-insight-edit-toggle/e2e/page-object.ts |
Page object pattern for E2E tests |
packages/atomic/src/components/insight/atomic-insight-edit-toggle/atomic-insight-edit-toggle.new.stories.tsx |
Storybook stories demonstrating component usage |
packages/atomic/src/components/insight/atomic-insight-edit-toggle/atomic-insight-edit-toggle.mdx |
Storybook documentation |
packages/atomic/src/components/insight/index.ts |
Added export for Lit component |
packages/atomic/src/components/insight/lazy-index.ts |
Added lazy loading configuration |
packages/atomic-react/src/components/search/components.ts |
Added React wrapper |
packages/atomic-react/src/components/commerce/components.ts |
Added React wrapper |
packages/atomic/src/components.d.ts |
Removed Stencil-generated type definitions |
packages/atomic/src/utils/custom-element-tags.ts |
Registered component tag |
packages/atomic/src/images/edit.svg |
Minified SVG (single line for better Storybook import) |
packages/atomic/.storybook/main.ts |
Updated SVG transform to strip newlines |
.github/prompts/migrate-stencil-to-lit.prompt.md |
Updated migration guide with SVG import exception |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
β Checklist
.mdxfileindex.tsandlazy-index.tsfiles.https://coveord.atlassian.net/browse/KIT-4873