Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 19, 2025

βœ… Checklist

  • πŸ§ͺ The component is unit tested
  • πŸ§ͺ The component includes E2E tests
  • πŸ—‘οΈ Old Cypress tests exclusive to the component are removed
  • πŸ“– The component is documented in storybook with an .mdx file
  • β™Ώ The component complies with the Web Content Accessibility Guidelines.
  • 🌐 All strings intended for humans or assistive technology must be localized with i18n.
  • πŸ“¦ The Lit component is exported in the appropriate index.ts and lazy-index.ts files.
  • 🎨 CSS parts are documented still accessible.
  • πŸ¦₯ Slotted Content, public methods and properties are documented
  • πŸ”„ The component outputs the same Angular output as before with Stencil
  • 🏷️ The component declares the component type in the HTMLElementTagNameMap

https://coveord.atlassian.net/browse/KIT-4873

Copilot AI changed the title [WIP] Migrate atomic-insight-edit-toggle component to Lit feat(atomic): migrate atomic-insight-edit-toggle to Lit Dec 19, 2025
Copilot AI requested a review from alexprudhomme December 19, 2025 16:27
@alexprudhomme alexprudhomme changed the title feat(atomic): migrate atomic-insight-edit-toggle to Lit chore(atomic): migrate atomic-insight-edit-toggle to Lit Dec 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the atomic-insight-edit-toggle component from Stencil to Lit as part of the ongoing framework migration effort. The component provides an edit button for insight interfaces and is marked as internal.

Key Changes

  • Converted component from Stencil's JSX syntax to Lit's template system
  • Replaced Stencil decorators with Lit decorators (@customElement, @property)
  • Added comprehensive test coverage (unit tests and E2E tests)
  • Added Storybook documentation (stories and MDX file)

Reviewed changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/atomic/src/components/insight/atomic-insight-edit-toggle/atomic-insight-edit-toggle.ts New Lit component implementation replacing Stencil .tsx file
packages/atomic/src/components/insight/atomic-insight-edit-toggle/atomic-insight-edit-toggle.spec.ts New unit tests for the component
packages/atomic/src/components/insight/atomic-insight-edit-toggle/e2e/atomic-insight-edit-toggle.e2e.ts New E2E tests
packages/atomic/src/components/insight/atomic-insight-edit-toggle/e2e/fixture.ts E2E test fixture setup
packages/atomic/src/components/insight/atomic-insight-edit-toggle/e2e/page-object.ts Page object pattern for E2E tests
packages/atomic/src/components/insight/atomic-insight-edit-toggle/atomic-insight-edit-toggle.new.stories.tsx Storybook stories demonstrating component usage
packages/atomic/src/components/insight/atomic-insight-edit-toggle/atomic-insight-edit-toggle.mdx Storybook documentation
packages/atomic/src/components/insight/index.ts Added export for Lit component
packages/atomic/src/components/insight/lazy-index.ts Added lazy loading configuration
packages/atomic-react/src/components/search/components.ts Added React wrapper
packages/atomic-react/src/components/commerce/components.ts Added React wrapper
packages/atomic/src/components.d.ts Removed Stencil-generated type definitions
packages/atomic/src/utils/custom-element-tags.ts Registered component tag
packages/atomic/src/images/edit.svg Minified SVG (single line for better Storybook import)
packages/atomic/.storybook/main.ts Updated SVG transform to strip newlines
.github/prompts/migrate-stencil-to-lit.prompt.md Updated migration guide with SVG import exception

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alexprudhomme alexprudhomme added cross-team This PR is a collaboration between multiple teams high-confidence The author of the PR author has high confidence that it is correct. It should be ready to merge. labels Jan 7, 2026
@alexprudhomme alexprudhomme added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit 827d868 Jan 7, 2026
98 checks passed
@alexprudhomme alexprudhomme deleted the copilot/migrate-atomic-insight-edit-toggle branch January 7, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chromatic Opt-in w/ Chromatic cross-team This PR is a collaboration between multiple teams high-confidence The author of the PR author has high confidence that it is correct. It should be ready to merge. new-lit-component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants