fix(atomic-react): exclude insight components from search and commerce builds #6851
+9
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e builds Co-authored-by: alexprudhomme <[email protected]>
Copilot
AI
changed the title
[WIP] Remove insight component support from atomic-react
fix(atomic-react): exclude insight components from search and commerce builds
Dec 19, 2025
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build configuration issue where Lit-migrated insight components were incorrectly being included in atomic-react's search and commerce exports. The fix ensures insight components remain exclusive to their own use case and are not exposed through atomic-react's search or commerce interfaces.
Key Changes
- Added insight component directory exclusions to both build systems (Stencil and Lit build scripts)
- Removed incorrectly generated React wrapper exports for
AtomicInsightGenerateAnswerButtonandAtomicInsightInterfacefrom search and commerce component files - Ensured consistent exclusion patterns across both legacy Stencil-based and new Lit-based build processes
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/atomic/stencil.config.ts |
Added insight component filtering to excludeComponents for both search and commerce React output targets |
packages/atomic-react/scripts/build-lit.mjs |
Added src/components/insight to excludedComponentDirectories for both search and commerce build entries |
packages/atomic-react/src/components/search/components.ts |
Removed incorrectly generated React wrapper exports for insight components from search build |
packages/atomic-react/src/components/commerce/components.ts |
Removed incorrectly generated React wrapper exports for insight components from commerce build |
The changes are consistent, complete, and properly address the issue across both build systems. No issues were found with the implementation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexprudhomme
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Collaborator
louis-bompart
left a comment
louis-bompart
left a comment
There was a problem hiding this comment.
I'm wondering if there might be any usage of those in the wild.
@coveo/knowledge-ui-kit-reviewers
alexprudhomme
added
cross-team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The insight components should NOT be part of the atomic-react search and commerce builds.