Skip to content

Conversation

@mgrabina
Copy link

@mgrabina mgrabina commented Dec 10, 2025

Elena raised that from Aave we were blocking some requests for the AAVE icon on the explorer. Let's use the public one in GH so we don't need to change our internal policies.

Summary by CodeRabbit

  • New Features
    • Three new Aave v3 flashloan integrations are now available to all users: collateral swap enables seamless collateral exchanges, debt swap facilitates flexible debt position management, and repay with collateral provides enhanced options for collateral based repayments. These new integrations expand overall platform functionality and are live on the Sepolia testnet.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Dec 10, 2025

@mgrabina is attempting to deploy a commit to the cow Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

Walkthrough

Three new Aave flashloan entries were added to the hookDappsRegistry: collateral-swap, debt-swap, and repay-with-collateral. Each entry is configured as an EXTERNAL type with identical metadata structure including Aave branding, version 0.0.1, and support for Sepolia network.

Changes

Cohort / File(s) Summary
Registry entries
libs/hook-dapp-lib/src/hookDappsRegistry.ts
Added three new Aave flashloan entries (collateral-swap, debt-swap, repay-with-collateral) to the public hookDappsRegistry map. Each entry configured with EXTERNAL type, Aave metadata, and Sepolia network support (11155111).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward registry entries with repetitive, identical structure across three additions
  • No logic changes or complex interactions to validate
  • Focus: Verify correct registry keys and network ID configuration

Possibly related PRs

Suggested reviewers

  • elena-zh
  • shoom3301

Poem

🐰 Three flashloans hop into the registry so bright,
Aave's collateral and debt swaps taking flight,
Repay-with-collateral joins the queue,
Sepolia's chain, now these dapps run true! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides context for the issue but lacks structured sections (Summary, To Test, Background) and testing steps as defined in the template. Add the PR template sections with issue reference, testing steps with checkboxes, and any relevant background information for better clarity and consistency.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly addresses the main change—updating AAVE icon URLs to use GitHub URLs to resolve explorer blocking issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b65233 and 1e04e4b.

📒 Files selected for processing (1)
  • libs/hook-dapp-lib/src/hookDappsRegistry.ts (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-08-12T05:57:08.021Z
Learnt from: shoom3301
Repo: cowprotocol/cowswap PR: 6138
File: libs/hook-dapp-lib/src/hookDappsRegistry.ts:1-1
Timestamp: 2025-08-12T05:57:08.021Z
Learning: The matchHooksToDapps function in libs/hook-dapp-lib/src/utils.ts provides backward compatibility for permit hooks through function selector detection (EIP_2612_PERMIT_SELECTOR and DAI_PERMIT_SELECTOR) rather than dappId matching, making it robust against dappId changes.

Applied to files:

  • libs/hook-dapp-lib/src/hookDappsRegistry.ts
📚 Learning: 2025-07-18T08:07:55.497Z
Learnt from: alfetopito
Repo: cowprotocol/cowswap PR: 5992
File: libs/tokens/src/const/tokensList.json:135-167
Timestamp: 2025-07-18T08:07:55.497Z
Learning: Token lists for CoW Swap are maintained in a separate repository at https://github.com/cowprotocol/token-lists, not in the main cowswap repository. Issues related to missing token lists should be tracked in the token-lists repository.

Applied to files:

  • libs/hook-dapp-lib/src/hookDappsRegistry.ts
📚 Learning: 2025-05-26T12:39:29.009Z
Learnt from: cowdan
Repo: cowprotocol/cowswap PR: 5715
File: libs/common-const/src/tokens.ts:539-555
Timestamp: 2025-05-26T12:39:29.009Z
Learning: The team accepts using NATIVE_CURRENCY_ADDRESS as a temporary placeholder for COW token contract addresses on new networks (Polygon, Avalanche) until actual COW contracts are deployed.

Applied to files:

  • libs/hook-dapp-lib/src/hookDappsRegistry.ts
🔇 Additional comments (1)
libs/hook-dapp-lib/src/hookDappsRegistry.ts (1)

197-232: Aave flashloan hooks look consistent; consider de‑duplicating metadata and verify new icon URL.

The three new Aave flashloan entries are structurally consistent with the rest of hookDappsRegistry, and the raw.githubusercontent.com image source aligns with the PR goal of serving the icon from GitHub. Adding them under new cow-sdk://flashloans/aave/v3/* IDs is safe with respect to permit‑hook matching, which is selector‑based, not dappId‑based.

Two optional suggestions:

  1. Avoid repeated Aave metadata
    You repeat name, type, version, website, image, and conditions across all three entries. If more Aave flashloan hooks are added later, consider factoring out a helper or constant to centralize this metadata and only override the description fields per entry.

  2. Verify the new GitHub icon URL resolves
    Since the main change is the new icon host, confirm the URL is reachable and returns 200 in your target environments:

    https://raw.githubusercontent.com/aave/interface/refs/heads/main/public/icons/tokens/aave.svg
    

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mgrabina mgrabina changed the base branch from develop to main December 10, 2025 14:49
@shoom3301
Copy link
Collaborator

@mgrabina thank you! Could you merge the conflicts, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants