Skip to content

Conversation

@alandefreitas
Copy link
Collaborator

No description provided.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +678 to +682
if (config_->inheritBaseMembers != PublicSettings::BaseMemberInheritance::Never)
{
if (auto const* baseDecl = BT->getAsCXXRecordDecl())
{
if (auto const* baseDef = baseDecl->getDefinition();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Honor extract-implicit-specializations when visiting base classes

Base-class traversal now unconditionally calls getDefinition()/traverse(baseDef) whenever base-member inheritance is enabled, but this block no longer checks config_->extractImplicitSpecializations. With extract-implicit-specializations: false (the documented way to avoid instantiating implicit template specializations), a derived type such as struct A : B<int> will still instantiate and traverse the implicit specialization B<int> because this code runs before the guarded specialization handling. That bypasses the user setting and forces implicit specializations to be extracted even when explicitly disabled.

Useful? React with 👍 / 👎.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://1109.mrdocs.prtest2.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-11-20 07:37:23 UTC

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.33%. Comparing base (788c1ba) to head (e112fc1).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1109      +/-   ##
===========================================
+ Coverage    85.30%   85.33%   +0.02%     
===========================================
  Files          306      306              
  Lines        22426    22441      +15     
===========================================
+ Hits         19131    19150      +19     
+ Misses        3295     3291       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alandefreitas alandefreitas merged commit 05f5852 into cppalliance:develop Nov 20, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants