Skip to content

Conversation

@nickelpro
Copy link
Contributor

Fixes: #5

Unsure if it's desirable to allow this inside requirement as well. Conservatively I'm against it. If it's absolutely necessary we can add it later. Also on the fence about platform, but I think that allows CPS to be extended to environments the spec doesn't currently encompass.

Copy link
Member

@mwoehlke mwoehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not convinced there is consensus on the name. See #5 (comment).

Comment on lines +592 to +593
Vendors are *strongly* encouraged to record a ``version`` field in the
|package| vendor object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Vendors are *strongly* encouraged to record a ``version`` field in the
|package| vendor object.
Vendors are *strongly* encouraged to record a ``version`` field
in the |package| vendor object.

However, it isn't clear what the intent is, here, and if you're essentially proposing that tools creating CPS files record their identity version... I'm not necessarily opposed (although if we're going to recommend that, I would much rather we do so as a supplemental schema), but I'm less convinces that should be done for the sake of "versioning" extensions. I would rather the extensions themselves be versioned so Tool A can potentially write extensions for Tool B. Maybe this is redundant, but the extension tag and namespace are already redundant any time an extension is used.

An example would also be beneficial. I actually wouldn't mind seeing a full documentation page on extensions.

Comment on lines +589 to +590
Records vendor-specific extensions to CPS metadata. Vendors should ensure the
namspace they record in the vendor object is consistent across all scopes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Records vendor-specific extensions to CPS metadata. Vendors should ensure the
namspace they record in the vendor object is consistent across all scopes.
Records vendor-specific extensions to CPS metadata.
Vendors should ensure that
the namspace they record in the vendor object
is consistent across all scopes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use a tools section, rather than X-tool

2 participants