feat(Notification) Add template file support for Telegram notifications #1520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turric4n
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
It would be nice to load Telegram notification template from file.
So the following PR adds :
Support for loading Telegram notification template from file
This change allows Telegram notification templates to be loaded from a file using the new templateFile configuration option (or the DIUN_NOTIF_TELEGRAM_TEMPLATEFILE environment variable). If templateBody is empty and templateFile is provided, the file content will be used as the message template.
Note : Take a look at commit - refactor: Replace GetSecret with GetValueOrFileContents for improved secret or template retrieval