Asset serving #31
Merged
Asset serving #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Handler is now a description, whilst the actual handling is carried out by a RouteHandler. This allows a Handler to construct Resources when it builds a RouteHandler. This will be used by the asset pipeline to construct file watchers. This requires the Runtime be factored into two parts, one available before the http4s server is constructed, and one available after it is constructed.
This will store the cache busting asset handler
- Rename `assets` to `asset`, following convention of singular, not plural, package names. - Extract `HashingFileWatcher` from `AssetRoute` and start adding tests - Create type for hex encoded strings
- Add ScalaDoc - Use a normal ADT for events, instead of trying to be clever with a union type
This is caused by our dependency on HexFormat, but Scala is moving towards this as a minimum JDK dependency so it shouldn't cause us a problem.
Still work to do, but this fixes compilation errors.
Test is more robust and runs a bit faster
- Allow adjusting polling interval so that MacOS can increase the interval - Make test more robust by halting when all events have been observed, instead of simple sampling in a duration.
Use FileNameHasher for more testable code
Not sure I want to go this route, but will keep it for now.
- the BaseRuntime can accumulate resources that will be built when the KropRuntime is made - Supplying a key allows these resources to fetched from the KropRuntime
This is what we want for asset serving
- Add module name so it gets published under a useful name - Remove unused dependencies
- AssetRoute can actually be used in an application :-) - Refactoring of Route & Handler types to be more ergonomic
This test is intermittently failing on CI. Give it longer to run.
This is preventing CI from completing
Handlers are context functions that has access to the KropRuntime, so they can access the KropRuntime if they want to.
- Add documentation to asset method - Returned path includes the AssetRoute's base, and so is suitable for use as an href. - Small amount of cleanup - Add convenience constructor
CI continues to fail on this test, so give it longer to run
So asset documentation can compile
Only fails on Github Actions!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In development mode we don't want the web browser to cache assets, such as JS or CSS, that are under development. This PR implements this feature, which consists of a type of
Routefor managing assets. It:pathToby replaces file names with the file name + hash