removed memory printing #5 #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes the memory usage tracking functionality from the v5 script version of the assembly algorithm. The memory test flag was getting stuck on, causing unwanted memory profiling behavior.
Changes:
- Removed the
maxMemoryUsage()function that read Linux-specific/proc/self/statusmemory information - Removed the call to
maxMemoryUsage()in the main function that was conditionally compiled for Linux
Comments suppressed due to low confidence (1)
v5/main.cpp:1
- The
memTestflag in v5/globalPrimitives.h line 31 is now unused after removing the memory tracking functionality. Consider removing this flag from the global primitives and updating the related flag parsing logic in v5/ioflag.h (lines 47-53, 84-85) and documentation in v5/help.h (line 15) to avoid confusion and maintain code cleanliness.
#include <iostream>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory test flag is stuck on for the script version #5