ci(cryostat3): build and test against cryostat 3.0 #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Sample run: https://github.com/andrewazores/cryostat-core/actions/runs/8009669029/job/21878906203?pr=3 Failing because there are breaking changes in -core 2.29.0 which none of the dependent projects have been updated for yet. |
aali309
approved these changes
Feb 22, 2024
Member
Author
|
Just to be sure this is working properly, I have opened #354 . After that is merged I will do an upstream |
andrewazores
force-pushed
the
ci-build-3
branch
from
dcd108f to
a548e39
Compare
Member
Author
|
-core 2.29.0 is out and cryostat3 is updated for it. Updated sample runs look good: https://github.com/andrewazores/cryostat-core/actions/runs/8011523921/job/21885312715?pr=3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #352
Still TODO: the
pom.xmlbuild.archproperty isn't used for multiarch builds anymore, and the CI build for 3.0 only builds foramd64. This can be updated to usebuildahto produce a multiarch build.