Fix function-summary printer incorrectly reporting internal calls as external #2840
+322
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…external Fixes crytic#2073 The function-summary printer was incorrectly classifying all member access expressions (x.foo()) as external calls, including: - Solidity built-ins: abi.encode(), abi.decode(), etc. - Library calls: SafeMath.add(), both direct and via 'using X for Y' - Struct field access: data.value Changes: - solc_parsing/cfg/node.py: Add _classify_calls() to properly filter Solidity built-ins and direct library calls at parse time - core/declarations/function_contract.py: Use IR-based high_level_calls minus library_calls for accurate external call reporting in get_summary() - core/declarations/function_top_level.py: Same fix for top-level functions - tests/e2e/printers/: Add regression test covering all cases Note: this.foo() is correctly classified as external (uses CALL opcode).
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2073
Problem
The function-summary printer incorrectly classified all member access expressions (
x.foo()) as external calls, including:abi.encode(),abi.decode()SafeMath.add()(direct and viausing X for Y)Solution
_classify_calls()for built-ins and direct library callshigh_level_calls - library_callsinget_summary()forusing X for YaccuracyIncludes regression test covering all cases.