Skip to content

Conversation

@RogerAK
Copy link
Collaborator

@RogerAK RogerAK commented Jun 20, 2024

Description

fixes #330
Added an option for the user to select a group of proteins, which can be used to plot a box plot and by if the user doesn't select a protein then as default all the proteins are selected and plotted.

Changes

  1. forms\data_preprocessing: Added a multiple choice form to select a group of proteins for all the methods, where a box plot can be plotted
  2. imputation, normalisation, transformation, plots: added a parameter for proteins_of_interest
  3. Also updated the test to the new structure
  4. custom_fields and base.py: Added a new PlotForm so that clean is called properly in data preprocessing plots

Testing

  1. Go through the preprocessing section and try plotting box plot in imputation, normalisation and transformation methods

PR checklist

Development

  • If necessary, I have updated the documentation (README, docstrings, etc.)
  • If necessary, I have created / updated tests.

Mergeability

  • main-branch has been merged into local branch to resolve conflicts
  • The tests and linter have passed AFTER local merge
  • The code has been formatted with black

Code review

  • I have self-reviewed my code.
  • At least one other developer reviewed and approved the changes

@github-actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  protzilla
  steps.py
  protzilla/data_analysis
  ptm_analysis.py
  protzilla/data_preprocessing
  filter_proteins.py
  normalisation.py
  outlier_detection.py
  peptide_filter.py
  plots.py 148-149
  transformation.py
  protzilla/importing
  peptide_import.py
  protzilla/methods
  data_analysis.py 631-641
  data_preprocessing.py
  importing.py 142
  ui/runs
  form_mapping.py 166-167
  views.py 38, 289-291
  ui/runs/forms
  base.py 105, 108-112
  custom_fields.py 88-89
  data_analysis.py 926-934, 962
  data_preprocessing.py 198-200, 227-229, 256-258, 291-293, 331-333, 374-376, 417-419, 456-459, 494-497, 533-536, 581-584
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants