-
-
Notifications
You must be signed in to change notification settings - Fork 0
Print execution duration in summary #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| .ifPresent(out::println); | ||
| } | ||
|
|
||
| private Duration getExecutionDuration() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth shifting this left into Query?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Not at the moment.
- We only use this here.
- It is easy enough to derive from the other query methods.
- It would have to be done on a per-testcase basis to deal with reruns.
| .ifPresent(out::println); | ||
| } | ||
|
|
||
| private Duration getExecutionDuration() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Not at the moment.
- We only use this here.
- It is easy enough to derive from the other query methods.
- It would have to be done on a per-testcase basis to deal with reruns.
🤔 What's changed?
Print total user code execution duration next to the (wall clock) test run duration.
⚡️ What's your motivation?
Fixes #39.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
See comments.
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.