Skip to content

Conversation

@davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Dec 15, 2025

🤔 What's changed?

Print total user code execution duration next to the (wall clock) test run duration.

⚡️ What's your motivation?

Fixes #39.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

See comments.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

.ifPresent(out::println);
}

private Duration getExecutionDuration() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth shifting this left into Query?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Not at the moment.

  1. We only use this here.
  2. It is easy enough to derive from the other query methods.
  3. It would have to be done on a per-testcase basis to deal with reruns.

@davidjgoss davidjgoss marked this pull request as ready for review December 15, 2025 11:27
@mpkorstanje mpkorstanje self-requested a review December 16, 2025 17:04
.ifPresent(out::println);
}

private Duration getExecutionDuration() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Not at the moment.

  1. We only use this here.
  2. It is easy enough to derive from the other query methods.
  3. It would have to be done on a per-testcase basis to deal with reruns.

@mpkorstanje mpkorstanje changed the title Add execution duration Print execution duration in summary Dec 18, 2025
@mpkorstanje mpkorstanje merged commit 71095ad into main Dec 18, 2025
@mpkorstanje mpkorstanje deleted the execution-timings branch December 18, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include time executing user code in summary

2 participants