chore: Update director endpoint naming #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Call it the record endpoint instead of client api
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- charts/currents/templates/_common.tpl: Language not supported
Comments suppressed due to low confidence (2)
docs/README.md:67
- The description still refers to 'client api', which may be confusing given the new 'record' naming. Consider updating the description to 'Base domain for the test reporter record endpoint'.
| `currents.domains.recordApiHost` | Base domain for the test reporter client api | "currents-record.localhost" |
samples/eks/eks-config.yaml:8
- [nitpick] The update for appHost from 'currents-app.eks.currents-sandbox.work' to 'currents.eks.currents-sandbox.work' appears unrelated to the director endpoint renaming. Please confirm if this change is intentional.
appHost: currents.eks.currents-sandbox.work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason I kept calling it API, (even though it's the
cyendpoint in prod). I don't think we want to call it cy, but let's call itrecord. To go along with the fact that you need a record key to communicate with it.