[CSR-2497] fix: enable s3 region to be configured #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the missing S3 region configuration by adding the necessary region parameters in various documentation and configuration files.
- Updated quickstart documentation to include the missing region field.
- Revised the developer guide to clarify secret creation.
- Added the region configuration parameter in both the documentation and Helm chart values.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/eks/quickstart.md | Added the region parameter for S3 configuration. |
| docs/developer-guide/README.md | Updated secret creation instructions for clarity. |
| docs/configuration.md | Introduced the objectStorage.region configuration. |
| charts/currents/values.yaml | Added region property to the objectStorage settings. |
Files not reviewed (1)
- charts/currents/templates/_common.tpl: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration for region was somehow missed during earlier testing.
This results in our system defaulting to 'auto', which works for R2 but not for S3, for S3 the region needs to be set.