TreeNode: set max-width

[ethan-james]

Fixes #3353

I added a max-width to TreeNode in order to stop it from overrunning the viewport width when the transform applied to indented thoughts exceeds the right padding. In order to do this, I needed to updated bulletWidth in LayoutTree in order to calculate the width of the bullet in the same way that it is calculated in Bullet. This might have unforeseen consequences, and I could duplicate that calculation inside TreeNode instead.

[ethan-james]

I also see that, at larger font sizes at widths exceeding the 560px breakpoint that I was targeting, we can also get some cutoff. I can try to fix that as part of this issue if you want.

[raineorshine]

Sure! You can address the other case in this PR unless it ends up being a bigger change.

It would be great to get a puppeteer snapshot test covering this at different screen widths. Setting puppeteer's window width can be tricky sometimes, but give it a try.

[ethan-james]

Sure! You can address the other case in this PR unless it ends up being a bigger change.

It would be great to get a puppeteer snapshot test covering this at different screen widths. Setting puppeteer's window width can be tricky sometimes, but give it a try.

I added some tests, and they showing that my approach has problems with thought annotations. Putting the max-width on TreeNode doesn't work well with the padding applied to annotations. I could refactor my work to push the max-width down to StaticThought or Editable, but I think that first I should try to finish up #3352 and see if this works better without the ThoughtAnnotation placeholder.

[raineorshine]

Okay, sounds good.

At the end we'll need to reduce this down to the fewest tests that are needed cover the behavior, since snapshot tests are expensive and we don't want to slow down the test suite unnecessarily.