Applystate.fontSize for 1em and Convert Checkbox sizing to rem
#3487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cindmichelle
force-pushed
the
convert-em-to-rem
branch
2 times, most recently
from
6f44a32 to
14e9398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3018
Description
state.fontSize) to the root element so1remreflects the user’s font size settingremvalues to respect the user-settings' fontsizeremunits instead ofemfor sizingRemove user-setting fontsize from AppComponent containerNot possible right now since many components inside AppComponent container still rely onemcss unit. Removing this would cause them to inheritfont-sizefrom<body/>(currently 16px from panda.config.ts). We can revisit after all of theem→remunit migration is complete.